Skip to content

Simplify uncore register updates

Andrzej Hajda intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v14 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- addressed comments by Andi, Jani and lkp,
- despite Jani objections Ive left 1st patch with hope he will change his mind, if not it can be safely ignored :),
- converted few more read/modifiy/write sequences in last patch,
- style adjustements to make checkpatch happy.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/i915/display: Use drm_device alias if defineddrivers/gpu/drm/i915/display/icl_dsi.c drivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_debugfs.c +4 more+12 -169 replies
2/4drm/i915/display: Use intel_uncore alias if defineddrivers/gpu/drm/i915/i915_irq.c+7 -70 replies
3/4drm/i915: make intel_uncore_rmw() write unconditionallydrivers/gpu/drm/i915/intel_uncore.h+4 -40 replies
4/4drm/i915: use proper helper for register updatesdrivers/gpu/drm/i915/display/intel_tc.c drivers/gpu/drm/i915/i915_irq.c drivers/gpu/drm/i915/intel_pm.c +1 more+112 -2122 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchAndi ShytiJani Nikula
1/4R-b A-b R-b A-b
2/4R-b
3/4R-b A-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Intel-gfx] [PATCH v2 0/4] Simplify uncore register updates

This patchset should not modify behaviour of the code (except patch 3). It just replaces sequence of uncore read/modify/write with single call. Moreover it replaces nested pointers with alias if there is one. All patches except 3rd, were generated using coccinelle (quite ugly) and adjusted in some cases by hand.

v2:
- addressed comments by Andi, Jani and lkp,
- despite Jani objections Ive left 1st patch with hope he will change his mind, if not it can be safely ignored :),
- converted few more read/modifiy/write sequences in last patch,
- style adjustements to make checkpatch happy.

Regards
Andrzej

Andrzej Hajda (4):
drm/i915/display: Use drm_device alias if defined drm/i915/display: Use intel_uncore alias if defined drm/i915: make intel_uncore_rmw() write unconditionally drm/i915: use proper helper for register updates

 drivers/gpu/drm/i915/display/icl_dsi.c        |   4 +-
 drivers/gpu/drm/i915/display/intel_display.c  |   3 +-
 .../drm/i915/display/intel_display_debugfs.c  |   2 +-
 drivers/gpu/drm/i915/display/intel_hotplug.c  |   2 +-
 drivers/gpu/drm/i915/display/intel_lvds.c     |  13 +-
 drivers/gpu/drm/i915/display/intel_opregion.c |   2 +-
 drivers/gpu/drm/i915/display/intel_tc.c       |   9 +-
 drivers/gpu/drm/i915/display/vlv_dsi.c        |   2 +-
 drivers/gpu/drm/i915/i915_irq.c               | 237 +++++++-----------
 drivers/gpu/drm/i915/intel_pm.c               |  60 ++---
 drivers/gpu/drm/i915/intel_uncore.h           |   8 +-
 drivers/gpu/drm/i915/vlv_suspend.c            |  28 +--
 12 files changed, 133 insertions(+), 237 deletions(-)
Signature · 1 line
2.34.1