Skip to content

File-based migration support and fixed-ram features

Nikolay Borisov qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 17 repliesIn review
  2. v211 patches 11 repliesSuperseded
  3. v1 RFC11 patches 0 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14migration: support file: uri for source migrationmigration/file.c migration/file.h migration/meson.build +1 more+36 -00 replies
2/14migration: Add support for 'file:' uri for incoming migrationmigration/file.c migration/file.h migration/migration.c+18 -01 reply
3/14migration: Initial support of fixed-ram feature for analyze-migration.pymigration/migration.c migration/migration.h migration/savevm.c +1 more+85 -191 reply
4/14io: Add generic pwritev/preadv interfaceinclude/io/channel.h io/channel.c+75 -02 replies
5/14io: implement io_pwritev for QIOChannelFileio/channel-file.c+25 -01 reply
6/14io: add and implement QIO_CHANNEL_FEATURE_SEEKABLE for channel fileinclude/io/channel.h io/channel-file.c+10 -01 reply
7/14migration/qemu-file: add utility methods for working with seekable channelsinclude/migration/qemu-file-types.h migration/qemu-file.c migration/qemu-file.h+64 -00 replies
8/14io: Add preadv support to QIOChannelFileio/channel-file.c+27 -01 reply
9/14migration: add qemu_get_buffer_atmigration/qemu-file.c migration/qemu-file.h+24 -01 reply
10/14migration/ram: Introduce 'fixed-ram' migration stream capabilityinclude/exec/ramblock.h migration/migration.c migration/migration.h +3 more+138 -213 replies
11/14migration: Refactor precopy ram loading codemigration/ram.c+80 -620 replies
12/14migration: Add support for 'fixed-ram' migration restoremigration/migration.h migration/ram.c+95 -20 replies
13/14tests: Add migrate_incoming_qmp helpertests/qtest/migration-helpers.c tests/qtest/migration-helpers.h+23 -01 reply
14/14tests/qtest: migration-test: Add tests for file-based migrationtests/qtest/migration-test.c+46 -01 reply

Reviews trailers per patch

5 of 14 patches have a Reviewed-by or Acked-by.

PatchDaniel P. Berrangé
1/14R-b
2/14R-b
3/14
4/14
5/14R-b
6/14R-b
7/14
8/14
9/14
10/14
11/14
12/14
13/14R-b
14/14

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/14] File-based migration support and fixed-ram features

Here's the 3rd version of file-based migration support [0]. For background check the cover letter of the initial. The main changes are :

- Updated commit message as per Daniel Berrange's suggestino for Patches 1-2

- Fixed tab in various pages

- Added comments better explaining how json_writer_start_object in qemu_savevm_state_header is matched and also squashed the analyze-migration.py parts into patch 3

- Reworked the way pwritv/preadv are introduced. Now there are generic callbacks in QIOChannel that are implemented for the QIOChannelFile.

- Separated the introduction of QEMUFile-related helpers from the patch introducing the io interfaces.

- Added qtests for the file-based migration as well as for the fixed-ram feature.

[0] https://lore.kernel.org/qemu-devel/[email protected]/

Nikolay Borisov (14):
migration: support file: uri for source migration
migration: Add support for 'file:' uri for incoming migration
migration: Initial support of fixed-ram feature for
analyze-migration.py
io: Add generic pwritev/preadv interface
io: implement io_pwritev for QIOChannelFile
io: add and implement QIO_CHANNEL_FEATURE_SEEKABLE for channel file migration/qemu-file: add utility methods for working with seekable
channels
io: Add preadv support to QIOChannelFile
migration: add qemu_get_buffer_at
migration/ram: Introduce 'fixed-ram' migration stream capability
migration: Refactor precopy ram loading code
migration: Add support for 'fixed-ram' migration restore
tests: Add migrate_incoming_qmp helper
tests/qtest: migration-test: Add tests for file-based migration

 include/exec/ramblock.h             |   7 +
 include/io/channel.h                |  50 +++++
 include/migration/qemu-file-types.h |   2 +
 io/channel-file.c                   |  61 ++++++
 io/channel.c                        |  26 +++
 migration/file.c                    |  38 ++++
 migration/file.h                    |  10 +
 migration/meson.build               |   1 +
 migration/migration.c               |  61 +++++-
 migration/migration.h               |   6 +
 migration/qemu-file.c               |  82 +++++++
 migration/qemu-file.h               |   4 +
 migration/ram.c                     | 328 +++++++++++++++++++++-------
 migration/savevm.c                  |  48 ++--
 qapi/migration.json                 |   2 +-
 scripts/analyze-migration.py        |  49 ++++-
 tests/qtest/migration-helpers.c     |  19 ++
 tests/qtest/migration-helpers.h     |   4 +
 tests/qtest/migration-test.c        |  46 ++++
 19 files changed, 743 insertions(+), 101 deletions(-)
 create mode 100644 migration/file.c
 create mode 100644 migration/file.h

--
2.34.1