PCI/ASPM: Fix L1SS issues
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | PCI/ASPM: Factor out L1 PM Substates configurationdrivers/ | +55 | 0 replies | |
| 2/3 | PCI/ASPM: Ignore L1 PM Substates if device lacks capabilitydrivers/ | +3 | 2 replies | |
| 3/3 | PCI/ASPM: Correct LTR_L1.2_THRESHOLD computationdrivers/ | +32 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Kuppuswamy Sathyanarayanan |
|---|---|
| Series | R-b |
| 1/3 | |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] PCI/ASPM: Fix L1SS issues
From: Bjorn Helgaas <[email protected]>
This is really late, but I think we have two significant issues with L1SS:
1) pcie_aspm_cap_init() reads from the L1SS capability even when it doesn't exist, so it reads PCI_COMMAND and PCI_STATUS instead and treats those as an L1SS Capability value.
2) encode_l12_threshold() encodes LTR_L1.2_THRESHOLD as smaller than requested, so ports may enter L1.2 when they should not.
These patches are intended to fix both issues.
Bjorn Helgaas (3):
PCI/ASPM: Factor out L1 PM Substates configuration PCI/ASPM: Ignore L1 PM Substates if device lacks capability PCI/ASPM: Correct LTR_L1.2_THRESHOLD computation
drivers/pci/pcie/aspm.c | 155 +++++++++++++++++++++++----------------- 1 file changed, 90 insertions(+), 65 deletions(-)
Signature · 1 line
2.25.1