Skip to content

RFC block: add and use init tagset helper

Chaitanya Kulkarni asahi ceph-devel linux-block linux-mmc linux-mtd linux-nvme linux-omap linux-remoteproc linux-s390 linux-scsi lkml llvm virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest21 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21block: add and use init tagset helperblock/blk-mq.c drivers/block/null_blk/main.c include/linux/blk-mq.h+28 -78 replies
2/21loop: use lib tagset init helperdrivers/block/loop.c+4 -80 replies
3/21nbd: use lib tagset init helperdrivers/block/nbd.c+3 -80 replies
4/21rnbd: use lib tagset init helperdrivers/block/rbd.c+5 -60 replies
5/21bsg-lib: use lib tagset init helperblock/bsg-lib.c+3 -60 replies
6/21rnbd-clt: use lib tagset init helperdrivers/block/rnbd/rnbd-clt.c+11 -140 replies
7/21virtio-blk: use lib tagset init helperdrivers/block/virtio_blk.c+5 -90 replies
8/21scsi: use lib tagset init helperdrivers/scsi/scsi_lib.c+5 -80 replies
9/21block: use lib tagset init helperblock/blk-mq.c+2 -50 replies
10/21amiflop: use lib tagset init helperdrivers/block/amiflop.c+3 -50 replies
11/21floppy: use lib tagset init helperdrivers/block/floppy.c+2 -50 replies
12/21mtip32xx: use lib tagset init helperdrivers/block/mtip32xx/mtip32xx.c+4 -90 replies
13/21z3ram: use lib tagset init helperdrivers/block/z2ram.c+2 -50 replies
14/21scm_blk: use lib tagset init helperdrivers/s390/block/scm_blk.c+3 -70 replies
15/21ubi: use lib tagset init helperdrivers/mtd/ubi/block.c+3 -80 replies
16/21mmc: core: use lib tagset init helperdrivers/mmc/core/queue.c+3 -60 replies
17/21dasd: use lib tagset init helperdrivers/s390/block/dasd_genhd.c+3 -60 replies
18/21nvme-core: use lib tagset init helper for I/O qdrivers/nvme/host/core.c+3 -80 replies
19/21nvme-core: use lib tagset init helper for adminqdrivers/nvme/host/core.c+2 -80 replies
20/21nvme-apple: use lib tagset init helperdrivers/nvme/host/apple.c+8 -170 replies
21/21nvme-pci: use lib tagset init helperdrivers/nvme/host/pci.c+7 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/21] block: add and use init tagset helper

Hi,

Add and use the helper to initialize the common fields of the tag_set such as blk_mq_ops, number of h/w queues, queue depth, command size, numa_node, timeout, BLK_MQ_F_XXX flags, driver data. This initialization is spread all over the block drivers. This avoids repetation of inialization code of the tag set in current block drivers and any future ones.

P.S. I'm aware of the EXPORT_SYMBOL_GPL() checkpatch warn just to make get some feedback to so I can remove the RFC tag.

-ck

Chaitanya Kulkarni (21):
block: add and use init tagset helper
loop: use lib tagset init helper
nbd: use lib tagset init helper
rnbd: use lib tagset init helper
bsg-lib: use lib tagset init helper
rnbd-clt: use lib tagset init helper
virtio-blk: use lib tagset init helper
scsi: use lib tagset init helper
block: use lib tagset init helper
amiflop: use lib tagset init helper
floppy: use lib tagset init helper
mtip32xx: use lib tagset init helper
z3ram: use lib tagset init helper
scm_blk: use lib tagset init helper
ubi: use lib tagset init helper
mmc: core: use lib tagset init helper
dasd: use lib tagset init helper
nvme-core: use lib tagset init helper for I/O q
nvme-core: use lib tagset init helper for adminq
nvme-apple: use lib tagset init helper
nvme-pci: use lib tagset init helper

 block/blk-mq.c                    | 27 ++++++++++++++++++++++-----
 block/bsg-lib.c                   |  9 +++------
 drivers/block/amiflop.c           |  8 +++-----
 drivers/block/floppy.c            |  7 ++-----
 drivers/block/loop.c              | 12 ++++--------
 drivers/block/mtip32xx/mtip32xx.c | 13 ++++---------
 drivers/block/nbd.c               | 11 +++--------
 drivers/block/null_blk/main.c     | 10 +++-------
 drivers/block/rbd.c               | 11 +++++------
 drivers/block/rnbd/rnbd-clt.c     | 25 +++++++++++--------------
 drivers/block/virtio_blk.c        | 14 +++++---------
 drivers/block/z2ram.c             |  7 ++-----
 drivers/mmc/core/queue.c          |  9 +++------
 drivers/mtd/ubi/block.c           | 11 +++--------
 drivers/nvme/host/apple.c         | 25 ++++++++-----------------
 drivers/nvme/host/core.c          | 21 +++++----------------
 drivers/nvme/host/pci.c           | 25 +++++++------------------
 drivers/s390/block/dasd_genhd.c   |  9 +++------
 drivers/s390/block/scm_blk.c      | 10 +++-------
 drivers/scsi/scsi_lib.c           | 13 +++++--------
 include/linux/blk-mq.h            |  5 +++++
 21 files changed, 109 insertions(+), 173 deletions(-)
Signature · 1 line
2.29.0