User-visible Config.in feature sub-options
Status from this message: Applied to master with those changes.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | package/mpd: fix reversed logic in tcp disablepackage/ | +2 | 2 replies | |
| 2/4 | package/mpd: add/enhance (kconfig + code) commentspackage/ package/ | +8 | 2 replies | |
| 3/4 | package/mpd: introduce id3tag feature dependencypackage/ package/ | +4 | 2 replies | |
| 4/4 | package/mpd: introduce sub-options for expat and yajlpackage/ package/ | +31 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [Buildroot] [PATCH v2 0/4] User-visible Config.in feature sub-options
As indicated, this is the patch based on our discussion. I gave it the version number 2, even if the content has little to do with the original patch. I also split it into a series, to allow for partial integration.
#1 just a bug fix
#2 add /modify comments -- mostly captures additional info, collected when
looking up features in meson_options.txt and the mpd manual
#3 id3tag is a necessary sub-feature for mp3 decoders, so make them select
the (already existing) sub-option, instead of doing their own selection and omitting id3tag
#4 introduce the sub-option logic for expat and yajl also; this cleans up
upnp configuration also
I would appreciate integration of 1-3. #3 actually solves a possible con- figuration error: if you configure mp3 playback, but forget id3tag, mp3 files will not be recognized by mpd.
I am open for discussion on #4. I can live with automatic dependencies based on libraries, aka
ifeq ($(BR2_PACKAGE_FOO),y) MPD_DEPENDENCIES += libfoo MPD_CONF_OPTS += -Dfoo=enabled else MPD_CONF_OPTS += -Dfoo=disabled endif
(works for me), but would prefer dependencies based on Config.in sub-options.
libicu handling remains unchanged. libicu adds approx. 40 MB to the compressed image; whoever needs this in his firmware is welcome to the additional feature in mpd. It has no discernable size impact here.
Andreas Ziegler (4):
package/mpd: fix reversed logic in tcp disable package/mpd: add/enhance (kconfig + code) comments package/mpd: introduce id3tag feature dependency package/mpd: introduce sub-options for expat and yajl
package/mpd/Config.in | 30 ++++++++++++++++++++++-------- package/mpd/mpd.mk | 33 +++++++++++++++++++++++---------- 2 files changed, 45 insertions(+), 18 deletions(-)
Signature · 6 lines
2.34.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot