Skip to content

Updates to ov9282 sensor driver

Dave Stevenson linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 23 repliesIn review
  2. v116 patches 35 repliesSuperseded

Changes in v2 from the cover letter

Collected the relevant R-b tags from Jacopo (many thanks)
Patch 5 - replaced macro OV9282_NUM_MODES with direct use of ARRAY_SIZE (Sakari) Patch 6 - reworded commit text (Jacopo)
Patch 7 - correct typo (250 instead of 151) (Jacopo)
Patch 8 - moved setting CSI2 clock mode from streamon to power on (Sakari) Patch 10 - double empty line removed (Jacopo)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16media: i2c: ov9282: Remove duplication of registersdrivers/media/i2c/ov9282.c+0 -60 replies
2/16media: i2c: ov9282: Split registers into common and mode specificdrivers/media/i2c/ov9282.c+47 -300 replies
3/16media: i2c: ov9282: Remove format code from the modedrivers/media/i2c/ov9282.c+3 -60 replies
4/16media: i2c: ov9282: Remove pixel rate from mode definitiondrivers/media/i2c/ov9282.c+7 -100 replies
5/16media: i2c: ov9281: Support more than 1 mode.drivers/media/i2c/ov9282.c+28 -183 replies
6/16media: i2c: ov9282: Correct HTS register for configured pixel ratedrivers/media/i2c/ov9282.c+2 -21 reply
7/16media: i2c: ov9282: Reduce vblank_min values based on testingdrivers/media/i2c/ov9282.c+1 -11 reply
8/16media: i2c: ov9282: Add selection for CSI2 clock modedrivers/media/i2c/ov9282.c+22 -20 replies
9/16media: i2c: ov9282: Add the properties from fwnodedrivers/media/i2c/ov9282.c+10 -20 replies
10/16media: i2c: ov9282: Action CID_VBLANK when set.drivers/media/i2c/ov9282.c+16 -160 replies
11/16media: i2c: ov9282: Add HFLIP and VFLIP supportdrivers/media/i2c/ov9282.c+51 -11 reply
12/16media: i2c: ov9282: Make V4L2_CID_HBLANK r/wdrivers/media/i2c/ov9282.c+21 -110 replies
13/16media: i2c: ov9282: Add selection API calls for cropping infodrivers/media/i2c/ov9282.c+75 -00 replies
14/16media: i2c: ov9282: Add support for 1280x800 and 640x400 modesdrivers/media/i2c/ov9282.c+102 -13 replies
15/16media: i2c: ov9282: Add support for 8bit readoutdrivers/media/i2c/ov9282.c+78 -1713 replies
16/16media: i2c: ov9282: Support event handlersdrivers/media/i2c/ov9282.c+9 -11 reply

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchJacopo Mondi
1/16R-b
2/16R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/16] Updates to ov9282 sensor driver

This series adds to the functionality of the Omnivision OV9282 driver to make it usable with libcamera.

Tested on a Raspberry Pi with OV9281 sensor (same as OV9282 but with alternate CRA on the optics)

Changes in v2
Collected the relevant R-b tags from Jacopo (many thanks)
Patch 5 - replaced macro OV9282_NUM_MODES with direct use of ARRAY_SIZE (Sakari) Patch 6 - reworded commit text (Jacopo)
Patch 7 - correct typo (250 instead of 151) (Jacopo)
Patch 8 - moved setting CSI2 clock mode from streamon to power on (Sakari) Patch 10 - double empty line removed (Jacopo)

No response on patch 11 with regard policy on whether V4L2_CID_VFLIP & HFLIP should be with regard sensor native orientation or initially submitted driver, so I've left it as is.

No response on patch 16 as to whether all sensor drivers with controls should have V4L2_SUBDEV_FL_HAS_EVENTS and subscribe_event/unsubscribe_event handlers, so again it's unchanged. It fixes a v4l2-compliance failure and therefore would appear to be valid.

Dave Stevenson (16):
media: i2c: ov9282: Remove duplication of registers
media: i2c: ov9282: Split registers into common and mode specific
media: i2c: ov9282: Remove format code from the mode
media: i2c: ov9282: Remove pixel rate from mode definition
media: i2c: ov9281: Support more than 1 mode.
media: i2c: ov9282: Correct HTS register for configured pixel rate
media: i2c: ov9282: Reduce vblank_min values based on testing
media: i2c: ov9282: Add selection for CSI2 clock mode
media: i2c: ov9282: Add the properties from fwnode
media: i2c: ov9282: Action CID_VBLANK when set.
media: i2c: ov9282: Add HFLIP and VFLIP support
media: i2c: ov9282: Make V4L2_CID_HBLANK r/w
media: i2c: ov9282: Add selection API calls for cropping info
media: i2c: ov9282: Add support for 1280x800 and 640x400 modes
media: i2c: ov9282: Add support for 8bit readout
media: i2c: ov9282: Support event handlers

 drivers/media/i2c/ov9282.c | 563 ++++++++++++++++++++++++++++++-------
 1 file changed, 456 insertions(+), 107 deletions(-)
Signature · 1 line
2.34.1