Skip to content

tests/qtest: Enable running qtest on Windows

Bin Meng qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 1 replyIn review

Changes in v5 from the cover letter

- Rebase on qemu/master
- Drop patches that are already merged
- Use g_autoptr(GError)
- Restore to v1 version which does not touch the posix implementation
- Replace sighandler_t with its actual definition, since it is not available on BSD hosts

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18semihosting/arm-compat-semi: Avoid using hardcoded /tmpsemihosting/arm-compat-semi.c+2 -10 replies
2/18tcg: Avoid using hardcoded /tmptcg/tcg.c+2 -10 replies
3/18util/qemu-sockets: Use g_get_tmp_dir() to get the directory for temporary filesutil/qemu-sockets.c+2 -30 replies
4/18tests/qtest: migration-test: Avoid using hardcoded /tmptests/qtest/migration-test.c+6 -40 replies
5/18block/vvfat: Unify the mkdir() callblock/vvfat.c+3 -60 replies
6/18fsdev/virtfs-proxy-helper: Use g_mkdir()fsdev/virtfs-proxy-helper.c+2 -10 replies
7/18hw/usb: dev-mtp: Use g_mkdir()hw/usb/dev-mtp.c+2 -20 replies
8/18accel/qtest: Support qtest accelerator for Windowsaccel/dummy-cpus.c accel/meson.build accel/qtest/meson.build +2 more+20 -60 replies
9/18tests/qtest: Use send/recv for socket communicationinclude/qemu/sockets.h tests/qtest/libqmp.c tests/qtest/libqtest.c +1 more+40 -40 replies
10/18tests/qtest: libqtest: Install signal handler via signal()tests/qtest/libqtest.c+3 -110 replies
11/18tests/qtest: Support libqtest to build and run on Windowstests/qtest/libqtest.c+93 -20 replies
12/18tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceledtests/qtest/migration-test.c+4 -00 replies
13/18tests/qtest: libqtest: Correct the timeout unit of blocking receive calls for win32tests/qtest/libqtest.c+10 -10 replies
14/18io/channel-watch: Drop a superfluous '#ifdef WIN32'io/channel-watch.c+0 -20 replies
15/18io/channel-watch: Drop the unnecessary castio/channel-watch.c+3 -30 replies
16/18io/channel-watch: Fix socket watch on Windowsio/channel-watch.c+0 -40 replies
17/18.gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes.gitlab-ci.d/windows.yml+2 -20 replies
18/18tests/qtest: Enable qtest build on Windowstests/qtest/meson.build+0 -60 replies

Reviews trailers per patch

15 of 18 patches have a Reviewed-by or Acked-by.

PatchAlex BennéeMarc-André LureauChristian SchoenebeckGerd HoffmannThomas Huth
1/18R-b
2/18R-b R-b
3/18R-b
4/18R-b
5/18R-b
6/18R-b
7/18A-b
8/18R-b
9/18R-b
10/18R-b
11/18R-b
12/18
13/18R-b
14/18R-b
15/18R-b
16/18
17/18
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/18] tests/qtest: Enable running qtest on Windows

In preparation to adding virtio-9p support on Windows, this series enables running qtest on Windows, so that we can run the virtio-9p tests on Windows to make sure it does not break accidently.

Changes in v5:
- Rebase on qemu/master
- Drop patches that are already merged
- Use g_autoptr(GError)
- Restore to v1 version which does not touch the posix implementation
- Replace sighandler_t with its actual definition, since it is not available on BSD hosts

Changes in v4:
- Update the error reporting by using the GError "error" argument of g_dir_make_tmp()
- Remove the const from tmpfs declaration

Changes in v3:
- Split to a separate patch
- Add a usleep(1) in the busy wait loop
- Drop the host test

Changes in v2:
- Use g_autofree to declare the variable
- Change to use g_mkdir()
- Change to use g_mkdir()
- Change to use g_mkdir()
- Introduce qemu_send_full() and use it
- Move the enabling of building qtests on Windows to a separate patch to keep bisectablity
- Call socket_init() unconditionally
- Add a missing CloseHandle() call
- Change to a busy wait after migration is canceled
- new patch: "io/channel-watch: Drop the unnecessary cast"
- Change the timeout limit to 90 minutes
- new patch: "tests/qtest: Enable qtest build on Windows"

Bin Meng (15):
semihosting/arm-compat-semi: Avoid using hardcoded /tmp
tcg: Avoid using hardcoded /tmp
util/qemu-sockets: Use g_get_tmp_dir() to get the directory for
temporary files
tests/qtest: migration-test: Avoid using hardcoded /tmp block/vvfat: Unify the mkdir() call fsdev/virtfs-proxy-helper: Use g_mkdir()
hw/usb: dev-mtp: Use g_mkdir()
tests/qtest: libqtest: Install signal handler via signal() tests/qtest: Support libqtest to build and run on Windows tests/qtest: libqtest: Correct the timeout unit of blocking receive
calls for win32
io/channel-watch: Drop a superfluous '#ifdef WIN32' io/channel-watch: Drop the unnecessary cast io/channel-watch: Fix socket watch on Windows .gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes tests/qtest: Enable qtest build on Windows

Xuzhou Cheng (3):
accel/qtest: Support qtest accelerator for Windows tests/qtest: Use send/recv for socket communication tests/qtest: migration-test: Make sure QEMU process "to" exited after
migration is canceled

 include/hw/core/cpu.h         |   1 +
 include/qemu/sockets.h        |   2 +
 accel/dummy-cpus.c            |  14 +++-
 block/vvfat.c                 |   9 +--
 fsdev/virtfs-proxy-helper.c   |   3 +-
 hw/usb/dev-mtp.c              |   4 +-
 io/channel-watch.c            |  12 +---
 semihosting/arm-compat-semi.c |   3 +-
 softmmu/cpus.c                |   9 +--
 tcg/tcg.c                     |   3 +-
 tests/qtest/libqmp.c          |   5 +-
 tests/qtest/libqtest.c        | 124 +++++++++++++++++++++++++++++-----
 tests/qtest/migration-test.c  |  14 ++--
 util/osdep.c                  |  33 +++++++++
 util/qemu-sockets.c           |   5 +-
 .gitlab-ci.d/windows.yml      |   4 +-
 accel/meson.build             |   1 +
 accel/qtest/meson.build       |   1 +
 tests/qtest/meson.build       |   6 --
 19 files changed, 194 insertions(+), 59 deletions(-)
Signature · 1 line
2.34.1