Skip to content

ASoC: Intel: avs: Fixes and new boards support

Cezary Rojewski alsa-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest15 patches 1 replyIn review
  2. v115 patches 1 replySuperseded

Changes in v2 from the cover letter

- no code changes, just added missing signed-off-by tags

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15ASoC: Intel: avs: Fix DMA mask assignmentsound/soc/intel/avs/core.c+1 -10 replies
2/15ASoC: Intel: avs: Fix potential RX buffer overflowsound/soc/intel/avs/ipc.c+2 -10 replies
3/15ASoC: codecs: rt298: Add quirk for KBL-R RVP platformsound/soc/codecs/rt298.c+7 -00 replies
4/15ASoC: Intel: avs: Add quirk for KBL-R RVP platformsound/soc/intel/avs/boards/rt298.c+22 -20 replies
5/15ASoC: Intel: avs: Support AML with rt286 configurationsound/soc/intel/avs/board_selection.c+6 -00 replies
6/15ASoC: Intel: avs: Support da7219 on both KBL and APLsound/soc/intel/avs/boards/da7219.c+5 -10 replies
7/15ASoC: Intel: avs: Add missing SKL-based device IDssound/soc/intel/avs/core.c+4 -00 replies
8/15ASoC: Intel: avs: Simplify d0ix disabling routinesound/soc/intel/avs/ipc.c+1 -10 replies
9/15ASoC: Intel: avs: Add missing include to HDA boardsound/soc/intel/avs/boards/hdaudio.c+1 -00 replies
10/15ASoC: Intel: avs: Do not reuse msg between different IPC handlerssound/soc/intel/avs/apl.c+4 -20 replies
11/15ASoC: Intel: avs: Do not treat unsupported IPCs as invalidsound/soc/intel/avs/avs.h sound/soc/intel/avs/messages.h+5 -10 replies
12/15ASoC: Intel: avs: Do not print IPC error message twicesound/soc/intel/avs/messages.c+4 -150 replies
13/15ASoC: Intel: avs: Simplify ignore_fw_version descriptionsound/soc/intel/avs/loader.c+1 -10 replies
14/15ASoC: Intel: avs: Simplify log control for SKLsound/soc/intel/avs/skl.c+2 -20 replies
15/15ASoC: codecs: hda: Fix spelling error in log messagesound/soc/codecs/hda.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/15] ASoC: Intel: avs: Fixes and new boards support

Two fixes are leading the way - one addresses the incorrect DMA mask assignment (typo) at driver probe. The other, fixes a potential buffer overflow when copying data received from firmware to kernel buffer. However unlikely, the fix should still be there.

Then a range of patches providing the support for:
- AML with rt286 (machine board)
- KBL-R for rt298 (codec)
- KBL-R with rt298 (machine board)
- APL/KBL with da7219 (machine board)
- Addition of all the missing SKL-based PCI ids to core.c

Of the remaining changes, only one stands out - special case is provided for "unsupported" IPCs. The driver supports a range of platforms, however, on some generations given IPC may not be supported. Such call shall not be treated as "invalid" - those are two different scenarios.

Everything else in the patchset is mostly a readability improvement:
spelling fixes and log messages issues, code simplification.

Changes in v2:
- no code changes, just added missing signed-off-by tags

Amadeusz Sławiński (4):
ASoC: codecs: rt298: Add quirk for KBL-R RVP platform
ASoC: Intel: avs: Add quirk for KBL-R RVP platform
ASoC: Intel: avs: Support da7219 on both KBL and APL
ASoC: Intel: avs: Add missing include to HDA board

Cezary Rojewski (11):
ASoC: Intel: avs: Fix DMA mask assignment
ASoC: Intel: avs: Fix potential RX buffer overflow
ASoC: Intel: avs: Support AML with rt286 configuration
ASoC: Intel: avs: Add missing SKL-based device IDs
ASoC: Intel: avs: Simplify d0ix disabling routine
ASoC: Intel: avs: Do not reuse msg between different IPC handlers
ASoC: Intel: avs: Do not treat unsupported IPCs as invalid
ASoC: Intel: avs: Do not print IPC error message twice
ASoC: Intel: avs: Simplify ignore_fw_version description
ASoC: Intel: avs: Simplify log control for SKL
ASoC: codecs: hda: Fix spelling error in log message

 sound/soc/codecs/hda.c                |  2 +-
 sound/soc/codecs/rt298.c              |  7 +++++++
 sound/soc/intel/avs/apl.c             |  6 ++++--
 sound/soc/intel/avs/avs.h             |  4 +++-
 sound/soc/intel/avs/board_selection.c |  6 ++++++
 sound/soc/intel/avs/boards/da7219.c   |  6 +++++-
 sound/soc/intel/avs/boards/hdaudio.c  |  1 +
 sound/soc/intel/avs/boards/rt298.c    | 24 ++++++++++++++++++++++--
 sound/soc/intel/avs/core.c            |  6 +++++-
 sound/soc/intel/avs/ipc.c             |  5 +++--
 sound/soc/intel/avs/loader.c          |  2 +-
 sound/soc/intel/avs/messages.c        | 19 ++++---------------
 sound/soc/intel/avs/messages.h        |  2 ++
 sound/soc/intel/avs/skl.c             |  4 ++--
 14 files changed, 66 insertions(+), 28 deletions(-)
Signature · 1 line
2.25.1