Skip to content

RFC block: add and use tagset init helper

Chaitanya Kulkarni linux-block llvm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6block: add and use tagset init helperblock/blk-mq.c drivers/block/null_blk/main.c include/linux/blk-mq.h+17 -60 replies
2/6nbd: use init alloc tagset helperdrivers/block/nbd.c+2 -50 replies
3/6virtio-blk: use init alloc tagset helperdrivers/block/virtio_blk.c+2 -50 replies
4/6nvme-apple: use init alloc tagset helperdrivers/nvme/host/apple.c+4 -101 reply
5/6nvme-core: use init alloc tagset helperdrivers/nvme/host/core.c+3 -100 replies
6/6nvme-pci: use init alloc tagset helperdrivers/nvme/host/pci.c+4 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/6] block: add and use tagset init helper

Hi,

The newly added helper blk_mq_init_alloc_tag_set() replaces existing call to blk_mq_alloc_tag_set() and takes following arguments to initialize tag_set before calling blk_mq_alloc_tag_set() :-

* blk_mq_ops
* number of h/w queues
* queue depth
* driver data

This approach is taken similar to what we have in the code where helper function is added to alloc and initialize the common code that was repeted in the callers :-

* 8c16567d867ed 5 args-init and alloc helper bio_alloc_bioset()
* 0a3140ea0fae3 5 args-init and alloc helper blk_next_bio()
* cdb14e0f7775e 4 args-init and alloc helper blk_mq_alloc_sq_tag_set()

With 5 arguments it shuold be easy to review and we don't have to extend the API even if tag_set gets a new member, I'll gradually change the drivers slowly to avoid one big treewide change.

This avoids code repetation of inialization code of tag set in current block drivers and any future ones.

-ck

Chaitanya Kulkarni (6):
block: add and use tagset init helper
nbd: use init alloc tagset helper
virtio-blk: use init alloc tagset helper
nvme-apple: use init alloc tagset helper
nvme-core: use init alloc tagset helper
nvme-pci: use init alloc tagset helper

 block/blk-mq.c                | 12 ++++++++++++
 drivers/block/nbd.c           |  7 ++-----
 drivers/block/null_blk/main.c |  7 ++-----
 drivers/block/virtio_blk.c    |  7 ++-----
 drivers/nvme/host/apple.c     | 14 ++++----------
 drivers/nvme/host/core.c      | 13 +++----------
 drivers/nvme/host/pci.c       |  5 ++++-
 include/linux/blk-mq.h        |  4 +++-
 8 files changed, 32 insertions(+), 37 deletions(-)
Signature · 1 line
2.29.0