Skip to content

Add a drm_crtc_helper_atomic_check() helper

Javier Martinez Canillas dri-devel lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v13 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- Reference drm_plane_helper_atomic_check() from drm_crtc_atomic_check() kernel doc comments and viceversa (Thomas Zimmermann).

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/mgag200: Do not call drm_atomic_add_affected_planes()drivers/gpu/drm/mgag200/mgag200_mode.c+1 -11 reply
2/4drm/simpledrm: Do not call drm_atomic_add_affected_planes()drivers/gpu/drm/tiny/simpledrm.c+2 -80 replies
3/4drm/ssd130x: Do not call drm_atomic_add_affected_planes()drivers/gpu/drm/solomon/ssd130x.c+2 -80 replies
4/4drm/crtc-helper: Add a drm_crtc_helper_atomic_check() helperdrivers/gpu/drm/drm_crtc_helper.c drivers/gpu/drm/drm_plane_helper.c drivers/gpu/drm/solomon/ssd130x.c +2 more+35 -250 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchThomas Zimmermann
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Add a drm_crtc_helper_atomic_check() helper

Add a helper function and make drivers that have the same logic in their struct drm_crtc_helper_funcs .atomic_check handler to use this instead.

Patch #1, #2 and #3 are just cleanups for the mgag200, simpledrm and ssd130x drivers respectively. Finally patch #4 converts the last two drivers to use a helper instead of open coding it the same logic.

The changes are inspired by a patch from Thomas Zimmermann for the ast DRM driver:

https://patchwork.kernel.org/project/dri-devel/patch/[email protected]/

This is a v2 that addresses issues pointed out also by Thomas in v1:

https://lists.freedesktop.org/archives/dri-devel/2022-October/375363.html

Best regards,
Javier

Changes in v2:
- Reference drm_plane_helper_atomic_check() from drm_crtc_atomic_check() kernel doc comments and viceversa (Thomas Zimmermann).

Javier Martinez Canillas (4):
drm/mgag200: Do not call drm_atomic_add_affected_planes() drm/simpledrm: Do not call drm_atomic_add_affected_planes() drm/ssd130x: Do not call drm_atomic_add_affected_planes() drm/crtc-helper: Add a drm_crtc_helper_atomic_check() helper

 drivers/gpu/drm/drm_crtc_helper.c      | 26 ++++++++++++++++++++++++++
 drivers/gpu/drm/drm_plane_helper.c     |  4 +++-
 drivers/gpu/drm/mgag200/mgag200_mode.c |  2 +-
 drivers/gpu/drm/solomon/ssd130x.c      | 20 ++------------------
 drivers/gpu/drm/tiny/simpledrm.c       | 20 ++------------------
 include/drm/drm_crtc_helper.h          |  2 ++
 6 files changed, 36 insertions(+), 38 deletions(-)
Signature · 1 line
2.37.3