Skip to content

Accumulate statistics over reset

Benjamin Mikailenko intel-wired-lan 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest2 patches 2 repliesIn review
  2. v72 patches 1 replySuperseded
  3. v62 patches 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v42 patches0 repliesSuperseded
v32 patches5 repliesSuperseded
v22 patches4 repliesSuperseded

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ice: Accumulate HW and Netdev statistics over resetdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_dcb_lib.c drivers/net/ethernet/intel/ice/ice_lib.c +1 more+37 -41 reply
2/2ice: Accumulate ring statistics over resetdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_ethtool.c drivers/net/ethernet/intel/ice/ice_lib.c +6 more+351 -611 reply

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchGurucharan G
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [Intel-wired-lan] [net-next, v8 0/2] Accumulate statistics over reset

Resets happen with or without user interaction. For example, incidents such as TX hang or a reconfiguration of parameters will result in a reset. During reset, hardware and software statistics were set to zero. This created an issue for the user where a reset happens in the background, statistics set to zero, and the user checks statistics expecting them to be populated.

Accumulate statistics over reset so the above doesn't happen.

Change is divided in two patches:
1. Accumulate HW and netdev statistics over reset
2. Accumulate ring statistics over reset

Benjamin Mikailenko (2):
ice: Accumulate HW and Netdev statistics over reset
ice: Accumulate ring statistics over reset

 drivers/net/ethernet/intel/ice/ice.h          |   7 +
 drivers/net/ethernet/intel/ice/ice_dcb_lib.c  |   3 +
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |  12 +-
 drivers/net/ethernet/intel/ice/ice_lib.c      | 240 +++++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_main.c     |  96 +++++--
 drivers/net/ethernet/intel/ice/ice_repr.c     |  10 +-
 drivers/net/ethernet/intel/ice/ice_txrx.c     |  40 ++-
 drivers/net/ethernet/intel/ice/ice_txrx.h     |  18 +-
 drivers/net/ethernet/intel/ice/ice_txrx_lib.c |   2 +-
 drivers/net/ethernet/intel/ice/ice_xsk.c      |  25 +-
 10 files changed, 388 insertions(+), 65 deletions(-)
Signature · 13 lines
v2: Fixed styling
v3: Allocate statistic structures when XDP is enabled
v4: Added revision notes
v5: Moved revision notes
v6: Removed unnecessary managed allocations and null checks
v7: Removed unnecessary managed frees
v8: Removed unused variables
2.34.3

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan