Skip to content

Enable Fallback DNS server when server is created

Christophe Ronco connman 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1dnsproxy: enable Fallback DNS server when created if neededsrc/dnsproxy.c+19 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] Enable Fallback DNS server when server is created

I have a DHCP server that do not send DNS servers along with IP address. I use the FallbackNameservers option in main.conf to handle this case.

After a board reboot or a connman restart, Fallback DNS servers are correctly displayed in service properties but DNS requests still fail.
If I disconnect and reconnect the service, DNS requests are OK.

DNS requests fail because Fallback servers are not enabled.

They are not enabled because when dnsproxy_default_changed is called, DNS servers are not created yet and enable_fallback does not do anything. Then when servers are created in create_server (dnsproxy.c), they are not enabled because they are fallback servers.

I made a patch to change the behavior in create_server and enable Fallback server if there is no other DNS servers.

Best Regards,
Christophe Ronco

Christophe Ronco (1):
dnsproxy: enable Fallback DNS server when created if needed

 src/dnsproxy.c | 28 +++++++++++++++++++---------
 1 file changed, 19 insertions(+), 9 deletions(-)
Signature · 1 line
2.25.1