RFC SVM guest shadow stack support
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 posting 2/29 patches 11 repliesIn review
- v3 RFC Latest8 patches 0 repliesNew
- v2 RFC posting 1/26 patches 19 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 RFC | 7 patches | 10 replies | Superseded |
Changes in v3 from the cover letter
- Rebased on v5 of the Intel CET virtualization series.
- Add patch changing the name of vmplX_ssp SEV-ES save area fields to plX_ssp.
- Merge this series intended for KVM with the separate guest kernel
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | KVM: x86: SVM: Emulate reads and writes to shadow stack MSRsarch/ | +18 | 0 replies | |
| 2/8 | KVM: x86: SVM: Update dump_vmcb with shadow stack save area additionsarch/ | +4 | 0 replies | |
| 3/8 | KVM: x86: SVM: Pass through shadow stack MSRsarch/ arch/ | +27 | 0 replies | |
| 4/8 | KVM: SVM: Rename vmplX_ssp -> plX_ssparch/ | +4 | 0 replies | |
| 5/8 | KVM: SVM: Save shadow stack host state on VMRUNarch/ | +9 | 0 replies | |
| 6/8 | KVM: SVM: Add MSR_IA32_XSS to the GHCB for hypervisor kernelarch/ arch/ arch/ +1 more | +13 | 0 replies | |
| 7/8 | x86/sev-es: Include XSS value in GHCB CPUID requestarch/ | +15 | 0 replies | |
| 8/8 | KVM: SVM: Add CET features to supported_xssarch/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [RFC PATCH v3 0/8] SVM guest shadow stack support
AMD Zen3 and newer processors support shadow stack, a feature designed to protect against ROP (return-oriented programming) attacks in which an attacker manipulates return addresses on the call stack in order to execute arbitrary code. To prevent this, shadow stacks can be allocated that are only used by control transfer and return instructions. When a CALL instruction is issued, it writes the return address to both the program stack and the shadow stack. When the subsequent RET instruction is issued, it pops the return address from both stacks and compares them. If the addresses don't match, a control-protection exception is raised.
Shadow stack and a related feature, Indirect Branch Tracking (IBT), are collectively referred to as Control-flow Enforcement Technology (CET). However, current AMD processors only support shadow stack and not IBT.
This series adds support for shadow stack in SVM guests and builds upon the support added in the CET guest support patch series [1]. Additional patches are required to support shadow stack enabled guests in qemu [2] and glibc [3].
[1]: CET guest support patches (v5)
https://lore.kernel.org/all/[email protected]/
[2]: CET qemu patches
https://patchwork.ozlabs.org/project/qemu-devel/patch/[email protected]/
[3]: glibc tree containing necessary updates
https://gitlab.com/x86-glibc/glibc/-/tree/users/hjl/cet/master/
---
v2:
- Rebased on v3 of the Intel CET virtualization series, dropping the patch that moved cet_is_msr_accessible to common code as that has been pulled into the Intel series.
- Minor change removing curly brackets around if statement introduced
in patch 6/6.
v3:
- Rebased on v5 of the Intel CET virtualization series.
- Add patch changing the name of vmplX_ssp SEV-ES save area fields to plX_ssp.
- Merge this series intended for KVM with the separate guest kernel
patch (now patch 7/8).
- Update MSR passthrough code to conditionally pass through shadow stack MSRS based on both host and guest support.
- Don't save PL0_SSP, PL1_SSP, and PL2_SSP MSRs on SEV-ES VMRUN as these are currently unused.
John Allen (8):
KVM: x86: SVM: Emulate reads and writes to shadow stack MSRs
KVM: x86: SVM: Update dump_vmcb with shadow stack save area additions
KVM: x86: SVM: Pass through shadow stack MSRs
KVM: SVM: Rename vmplX_ssp -> plX_ssp
KVM: SVM: Save shadow stack host state on VMRUN
KVM: SVM: Add MSR_IA32_XSS to the GHCB for hypervisor kernel x86/sev-es: Include XSS value in GHCB CPUID request
KVM: SVM: Add CET features to supported_xss
arch/x86/include/asm/svm.h | 9 +++--- arch/x86/kernel/sev-shared.c | 15 ++++++++++ arch/x86/kvm/svm/sev.c | 21 ++++++++++++-- arch/x86/kvm/svm/svm.c | 53 ++++++++++++++++++++++++++++++++++++ arch/x86/kvm/svm/svm.h | 2 +- 5 files changed, 93 insertions(+), 7 deletions(-)
Signature · 1 line
2.39.1