Skip to content

nilfs2 lockdep warning fixes

Ryusuke Konishi stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nilfs2: fix lockdep warnings in page operations for btree nodesfs/nilfs2/btnode.c fs/nilfs2/btnode.h fs/nilfs2/btree.c +7 more+155 -510 replies
2/2nilfs2: fix lockdep warnings during disk space reclamationfs/nilfs2/dat.c fs/nilfs2/inode.c fs/nilfs2/mdt.c +2 more+92 -210 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchRyusuke Konishi
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 4.14 0/2] nilfs2 lockdep warning fixes

Hi Greg,

please apply the following two cc-stable patches to 4.14-stable.

Ryusuke Konishi (2):
nilfs2: fix lockdep warnings in page operations for btree nodes
nilfs2: fix lockdep warnings during disk space reclamation

During testing nilfs2 filesystem with stable trees, I encountered a lockdep warning followed by a kernel panic (by panic_on_warn) only in 4.14-stable.

I found that the cause was the lack of these patches which are applied to other newer stable trees. I guess they were dropped since the first patch was not applicable as is due to a pagevec change.

After I manually applied them to 4.14, the panic and lockdep warning have gone. So, I believe these should be backported to 4.14-stable as well.

Thanks,
Ryusuke Konishi

 fs/nilfs2/btnode.c  |  23 ++++++-
 fs/nilfs2/btnode.h  |   1 +
 fs/nilfs2/btree.c   |  27 +++++---
 fs/nilfs2/dat.c     |   4 +-
 fs/nilfs2/gcinode.c |   7 +-
 fs/nilfs2/inode.c   | 159 ++++++++++++++++++++++++++++++++++++++++----
 fs/nilfs2/mdt.c     |  43 ++++++++----
 fs/nilfs2/mdt.h     |   6 +-
 fs/nilfs2/nilfs.h   |  16 ++---
 fs/nilfs2/page.c    |   7 +-
 fs/nilfs2/segment.c |  11 +--
 fs/nilfs2/super.c   |   5 +-
 12 files changed, 242 insertions(+), 67 deletions(-)
Signature · 1 line
2.31.1