Skip to content

Fix behavior of Git.pm in unsafe bare repositories

Michael McClimon git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 12 repliesIn review
  2. v11 patch 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Git.pm: add semicolon after catch statementperl/Git.pm+1 -10 replies
2/2setup: allow Git.pm to do unsafe repo checkingperl/Git.pm setup.c t/t9700-perl-git.sh +1 more+26 -012 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Fix behavior of Git.pm in unsafe bare repositories

This adds one commit on top of the last version, to avoid the security problem mentioned by Peff at [1]. It's possible this isn't the best way to go about this (and I would not really call myself a C programmer), but it's a minimal patch that seems to fix the problem.

I'm not sure if I need to document the new environment variable somewhere or not; it's really an internal-only thing, so I didn't do so this time around, but happy to if needed. Thanks!

[1] https://lore.kernel.org/git/[email protected]/

Michael McClimon (2):
Git.pm: add semicolon after catch statement
setup: allow Git.pm to do unsafe repo checking

 perl/Git.pm         |  3 ++-
 setup.c             |  3 +++
 t/t9700-perl-git.sh |  4 ++++
 t/t9700/test.pl     | 18 ++++++++++++++++++
 4 files changed, 27 insertions(+), 1 deletion(-)

Range-diff against v1:

1:  1337c855 = 1:  1337c855 Git.pm: add semicolon after catch statement
-:  -------- > 2:  273f77d1 setup: allow Git.pm to do unsafe repo checking
Signature · 1 line
2.38.1.130.g45c9f05c