Skip to content

PCI: qcom: Add basic interconnect support

Johan Hovold linux-arm-msm linux-devicetree linux-pci lkml 3 versions – Applied

Status from this message: Applied to pci/qcom, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 2 repliesApplied
  2. v22 patches 6 repliesSuperseded
  3. v12 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- remove intermediate assignment in error path (Mani)
- add WARN_ON_ONCE() as a reminder to anyone ever extending the driver with support for higher speeds to update the bandwidth table

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2dt-bindings: PCI: qcom: Add SC8280XP/SA8540P interconnectsDocumentation/devicetree/bindings/pci/qcom,pcie.yaml+20 -00 replies
2/2PCI: qcom: Add basic interconnect supportdrivers/pci/controller/dwc/pcie-qcom.c+76 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRob HerringManivannan SadhasivamBrian MasneyGeorgi Djakov
1/2R-b A-b
2/2R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/2] PCI: qcom: Add basic interconnect support

On Qualcomm platforms like SC8280XP and SA8540P interconnect bandwidth must be requested before enabling interconnect clocks.

Add basic support for managing an optional "pcie-mem" interconnect path by setting a low constraint before enabling clocks and updating it after the link is up.

This is specifically needed to prevent a crash on SC8280XP/SA8540P when the interconnect constraints are enforced during boot.

As support for these platforms was added in 6.1-rc1 it would be nice to have this merged as a fix for 6.1, but deferring for 6.2 works as well.

Johan

Changes in v3
- remove intermediate assignment in error path (Mani)
- add WARN_ON_ONCE() as a reminder to anyone ever extending the driver with support for higher speeds to update the bandwidth table

Changes in v2
- update the bindings so that the interconnect-names constraints apply to all platforms (Krzysztof)

Johan Hovold (2):
dt-bindings: PCI: qcom: Add SC8280XP/SA8540P interconnects
PCI: qcom: Add basic interconnect support

 .../devicetree/bindings/pci/qcom,pcie.yaml    | 20 +++++
 drivers/pci/controller/dwc/pcie-qcom.c        | 76 +++++++++++++++++++
 2 files changed, 96 insertions(+)
Signature · 1 line
2.37.3