Skip to content

drm/vmwgfx: fb, cursors and hashtable refactor

Zack Rusin dri-devel 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest17 patches 0 repliesNew
  2. v317 patches 3 repliesSuperseded
  3. v216 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v116 patches3 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17drm/vmwgfx: Write the driver id registersdrivers/gpu/drm/vmwgfx/vmwgfx_drv.c+34 -90 replies
2/17drm/vmwgfx: Fix frame-size warning in vmw_mksstat_add_ioctldrivers/gpu/drm/vmwgfx/vmwgfx_msg.c+29 -140 replies
3/17drm/vmwgfx: Refactor resource manager's hashtable to use linux/hashtable implementation.drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c+26 -360 replies
4/17drm/vmwgfx: Remove ttm object hashtabledrivers/gpu/drm/vmwgfx/ttm_object.c drivers/gpu/drm/vmwgfx/ttm_object.h drivers/gpu/drm/vmwgfx/vmwgfx_drv.c+9 -230 replies
5/17drm/vmwgfx: Refactor resource validation hashtable to use linux/hashtable implementation.drivers/gpu/drm/vmwgfx/vmwgfx_drv.c drivers/gpu/drm/vmwgfx/vmwgfx_drv.h drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +2 more+58 -660 replies
6/17drm/vmwgfx: Clean up cursor mobsdrivers/gpu/drm/vmwgfx/vmwgfx_kms.c drivers/gpu/drm/vmwgfx/vmwgfx_kms.h+267 -1930 replies
7/17drm/vmwgfx: Start diffing new mob cursors against old onesdrivers/gpu/drm/vmwgfx/vmwgfx_kms.c drivers/gpu/drm/vmwgfx/vmwgfx_kms.h+81 -260 replies
8/17drm/vmwgfx: Support cursor surfaces with mob cursordrivers/gpu/drm/vmwgfx/vmwgfx_kms.c drivers/gpu/drm/vmwgfx/vmwgfx_kms.h+50 -290 replies
9/17drm/vmwgfx: Diff cursors when using cmdsdrivers/gpu/drm/vmwgfx/vmwgfx_kms.c drivers/gpu/drm/vmwgfx/vmwgfx_kms.h+62 -600 replies
10/17drm/vmwgfx: Refactor ttm reference object hashtable to use linux/hashtable.drivers/gpu/drm/vmwgfx/ttm_object.c drivers/gpu/drm/vmwgfx/ttm_object.h drivers/gpu/drm/vmwgfx/vmwgfx_drv.c+56 -490 replies
11/17drm/vmwgfx: Remove vmwgfx_hashtabDocumentation/gpu/todo.rst drivers/gpu/drm/vmwgfx/Makefile drivers/gpu/drm/vmwgfx/ttm_object.c +5 more+12 -3030 replies
12/17drm/vmwgfx: Do not allow invalid bpp's for dumb buffersdrivers/gpu/drm/vmwgfx/vmwgfx_bo.c+15 -10 replies
13/17drm/vmwgfx: Port the framebuffer code to drm fb helpersdrivers/gpu/drm/vmwgfx/Kconfig drivers/gpu/drm/vmwgfx/Makefile drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +4 more+28 -9910 replies
14/17drm/vmwgfx: Remove explicit and broken vblank handlingdrivers/gpu/drm/vmwgfx/vmwgfx_drv.h drivers/gpu/drm/vmwgfx/vmwgfx_kms.c drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c +2 more+1 -1010 replies
15/17drm/vmwgfx: Add a mksstat counter for cotable resizesdrivers/gpu/drm/vmwgfx/vmwgfx_cotable.c drivers/gpu/drm/vmwgfx/vmwgfx_mksstat.h drivers/gpu/drm/vmwgfx/vmwgfx_msg.c+22 -90 replies
16/17drm/vmwgfx: Optimize initial sizes of cotablesdrivers/gpu/drm/vmwgfx/vmwgfx_cotable.c+14 -20 replies
17/17drm/vmwgfx: Fix a sparse warning in kernel docsdrivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c+0 -10 replies

Reviews trailers per patch

13 of 17 patches have a Reviewed-by or Acked-by.

PatchThomas HellströmZack RusinMartin KrastevMaaz MombasawalaMichael BanackThomas Zimmermann
1/17R-b R-b
2/17R-b R-b
3/17R-b R-b
4/17R-b R-b
5/17R-b
6/17
7/17
8/17
9/17
10/17R-b
11/17R-b R-b
12/17R-b R-b
13/17R-b R-b R-b
14/17R-b R-b R-b
15/17R-b R-b R-b
16/17R-b
17/17R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/17] drm/vmwgfx: fb, cursors and hashtable refactor

From: Zack Rusin <[email protected]>

v4: Fix one more LPK warning found in the "Fix frame-size warning in
vmw_mksstat_add_ioctl" change
v3: Add improvements suggested by Thomas for the fb port change and add a commit that fixes a sparse kernel doc warning
v2: Fix LKP and sparse reported issues

This is a bit larger series than usual but these are all connected in various ways. The most important changes around everything is centered include:
- finally getting rid of vmwgfx_hashtab and porting the driver to linux/hashtable
- cleaning up the cursor mob handling, which fixes a bunch of cursor issues on kde configs
- removing vmwgfx fb code and porting it to drm fb helpers
- removing vmwgfx faked vblank handling

The rest is largely support code to make the transition easier (with some igt fixes to get more of it running for regression testing). The result is removal of over 1000loc with no loss in functionality.

Maaz Mombasawala (5):
drm/vmwgfx: Refactor resource manager's hashtable to use
linux/hashtable implementation.
drm/vmwgfx: Remove ttm object hashtable drm/vmwgfx: Refactor resource validation hashtable to use
linux/hashtable implementation.
drm/vmwgfx: Refactor ttm reference object hashtable to use
linux/hashtable.
drm/vmwgfx: Remove vmwgfx_hashtab

Martin Krastev (1):
drm/vmwgfx: Fix frame-size warning in vmw_mksstat_add_ioctl

Michael Banack (4):
drm/vmwgfx: Clean up cursor mobs
drm/vmwgfx: Start diffing new mob cursors against old ones drm/vmwgfx: Support cursor surfaces with mob cursor drm/vmwgfx: Diff cursors when using cmds

Zack Rusin (7):
drm/vmwgfx: Write the driver id registers drm/vmwgfx: Do not allow invalid bpp's for dumb buffers drm/vmwgfx: Port the framebuffer code to drm fb helpers drm/vmwgfx: Remove explicit and broken vblank handling drm/vmwgfx: Add a mksstat counter for cotable resizes drm/vmwgfx: Optimize initial sizes of cotables drm/vmwgfx: Fix a sparse warning in kernel docs

 Documentation/gpu/todo.rst                 |  11 -
 drivers/gpu/drm/vmwgfx/Kconfig             |   7 -
 drivers/gpu/drm/vmwgfx/Makefile            |   4 +-
 drivers/gpu/drm/vmwgfx/ttm_object.c        | 123 ++-
 drivers/gpu/drm/vmwgfx/ttm_object.h        |  20 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.c         |  16 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf_res.c |  62 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c    |  29 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c        | 129 ++--
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.h        |  49 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c    |  15 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_fb.c         | 831 ---------------------
 drivers/gpu/drm/vmwgfx/vmwgfx_hashtab.c    | 199 -----
 drivers/gpu/drm/vmwgfx/vmwgfx_hashtab.h    |  83 --
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.c        | 641 ++++++++--------
 drivers/gpu/drm/vmwgfx/vmwgfx_kms.h        |  31 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c        |   8 -
 drivers/gpu/drm/vmwgfx/vmwgfx_mksstat.h    |   2 +
 drivers/gpu/drm/vmwgfx/vmwgfx_msg.c        |  59 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c       |  31 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c       |  26 -
 drivers/gpu/drm/vmwgfx/vmwgfx_validation.c |  55 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_validation.h |  26 +-
 23 files changed, 654 insertions(+), 1803 deletions(-)
 delete mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
 delete mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_hashtab.c
 delete mode 100644 drivers/gpu/drm/vmwgfx/vmwgfx_hashtab.h
Signature · 1 line
2.34.1