Skip to content

ASoC: SOF: Intel/IPC4: Support for external firmware libraries

Peter Ujfalusi alsa-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest19 patches 2 repliesIn review
  2. v119 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- rebased on "[PATCH v2] ASoC: SOF: Intel: pci-tgl: fix ADL-N descriptor"

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19ASoC: SOF: loader: Set complete state before post_fw_run opsound/soc/sof/loader.c+3 -30 replies
2/19ASoC: SOF: Introduce container struct for SOF firmwaresound/soc/sof/ipc3-loader.c sound/soc/sof/ipc4-loader.c sound/soc/sof/loader.c +1 more+41 -230 replies
3/19ASoC: SOF: amd: Use the basefw firmware container directlysound/soc/sof/amd/acp-loader.c+2 -40 replies
4/19ASoC: SOF: Intel: hda-loader: Use the basefw firmware container directlysound/soc/sof/intel/hda-loader.c+5 -60 replies
5/19ASoC: SOF: Intel: hda-loader-skl: Use the basefw firmware container directlysound/soc/sof/intel/hda-loader-skl.c+3 -40 replies
6/19ASoC: SOF: Drop the firmware and fw_offset from snd_sof_pdatainclude/sound/sof.h sound/soc/sof/loader.c+0 -130 replies
7/19ASoC: SOF: ipc: ops: Add support for optional init and exit callbackssound/soc/sof/ipc.c sound/soc/sof/sof-priv.h+12 -00 replies
8/19ASoC: SOF: ipc4-loader: Save the maximum number of libraries supportedsound/soc/sof/ipc4-loader.c sound/soc/sof/ipc4-priv.h+10 -00 replies
9/19ASoC: SOF: ipc4: Convert the firmware handling (loader) to library conventionsound/soc/sof/ipc4-loader.c sound/soc/sof/ipc4-priv.h sound/soc/sof/ipc4-topology.c +1 more+113 -370 replies
10/19ASoC: SOF: IPC4: Add helper for looking up module by UUIDsound/soc/sof/ipc4-loader.c sound/soc/sof/ipc4-priv.h sound/soc/sof/ipc4-topology.c+27 -140 replies
11/19ASoC: SOF: Add path definition for external firmware librariesinclude/sound/sof.h sound/soc/sof/intel/pci-tgl.c sound/soc/sof/sof-pci-dev.c+34 -10 replies
12/19ASoC: SOF: Intel: Set the default firmware library path for IPC4sound/soc/sof/intel/pci-apl.c sound/soc/sof/intel/pci-cnl.c sound/soc/sof/intel/pci-icl.c +2 more+45 -00 replies
13/19ASoC: SOF: ipc4: Define platform dependent library loading callbacksound/soc/sof/ipc4-priv.h+5 -00 replies
14/19ASoC: SOF: Intel: hda: Add flag to indicate that the firmware is IMR bootedsound/soc/sof/intel/hda-loader.c sound/soc/sof/intel/hda.h+6 -10 replies
15/19ASoC: SOF: Intel: Add ipc4 library loading implementationinclude/sound/sof/ipc4/header.h sound/soc/sof/intel/apl.c sound/soc/sof/intel/cnl.c +5 more+88 -00 replies
16/19ASoC: SOF: loader: Add support for IPC dependent post firmware boot opssound/soc/sof/loader.c sound/soc/sof/sof-priv.h+9 -00 replies
17/19ASoC: SOF: ipc4: Stop using the query_fw_configuration fw_loader opssound/soc/sof/ipc4-loader.c sound/soc/sof/ipc4-priv.h sound/soc/sof/ipc4.c+11 -20 replies
18/19ASoC: SOF: loader: Remove the query_fw_configuration opssound/soc/sof/loader.c sound/soc/sof/sof-priv.h+2 -120 replies
19/19ASoC: SOF: ipc4-loader: Support for loading external librariessound/soc/sof/ipc4-loader.c sound/soc/sof/ipc4-priv.h sound/soc/sof/ipc4.c+153 -60 replies

Reviews trailers per patch

All 19 patches have a Reviewed-by or Acked-by.

PatchRanjani SridharanPierre-Louis BossartChao SongKai Vehmanen
1/19R-b R-b R-b R-b
2/19R-b R-b R-b R-b
3/19R-b R-b R-b R-b
4/19R-b R-b R-b R-b
5/19R-b R-b R-b R-b
6/19R-b R-b R-b R-b
7/19R-b R-b R-b R-b
8/19R-b R-b R-b R-b
9/19R-b R-b R-b R-b
10/19R-b R-b R-b R-b
11/19R-b R-b R-b R-b
12/19R-b R-b R-b R-b
13/19R-b R-b R-b R-b
14/19R-b R-b R-b R-b
15/19R-b R-b R-b R-b
16/19R-b R-b R-b R-b
17/19R-b R-b R-b R-b
18/19R-b R-b R-b R-b
19/19R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/19] ASoC: SOF: Intel/IPC4: Support for external firmware libraries

Hi,

Changes since v1:
- rebased on "[PATCH v2] ASoC: SOF: Intel: pci-tgl: fix ADL-N descriptor"

Cover letter:

In IPC4 all DSP loadable executable is a 'library' containing modules. The main or basefw is also a library which contains multiple modules.
IPC4 allows to use loadable libraries to extend the functionality of the booted basefw.

This series adds support for loading external libraries in case they are needed by the loaded topology file.

The libraries must be placed to a specific firmware directory (fw_lib_prefix), which is:
intel/avs-lib|sof-ipc4-lib/ followed by the platform name and in case of community key use a 'community' directory.

For example for upx-i11 (community key): intel/avs-lib/tgl/community is the default path.

The name of the library should be the UUID of the module it contains since the library loading is going to look for the file as <module_UUID>.bin In case there is a need to bundle multiple modules into single library, symlinks can be used to point to the file:

module_boundle.bin
<UUID1>.bin -> module_boundle.bin
<UUID2>.bin -> module_boundle.bin
<UUID3>.bin -> module_boundle.bin

But note that in this case all modules will be loaded to the DSP since only the whole library can be loaded, not individual modules.

Regards,
Peter
---
Peter Ujfalusi (18):
ASoC: SOF: Introduce container struct for SOF firmware
ASoC: SOF: amd: Use the basefw firmware container directly
ASoC: SOF: Intel: hda-loader: Use the basefw firmware container
directly
ASoC: SOF: Intel: hda-loader-skl: Use the basefw firmware container
directly
ASoC: SOF: Drop the firmware and fw_offset from snd_sof_pdata
ASoC: SOF: ipc: ops: Add support for optional init and exit callbacks
ASoC: SOF: ipc4-loader: Save the maximum number of libraries supported
ASoC: SOF: ipc4: Convert the firmware handling (loader) to library
convention
ASoC: SOF: IPC4: Add helper for looking up module by UUID
ASoC: SOF: Add path definition for external firmware libraries
ASoC: SOF: Intel: Set the default firmware library path for IPC4
ASoC: SOF: ipc4: Define platform dependent library loading callback
ASoC: SOF: Intel: hda: Add flag to indicate that the firmware is IMR
booted
ASoC: SOF: Intel: Add ipc4 library loading implementation
ASoC: SOF: loader: Add support for IPC dependent post firmware boot
ops
ASoC: SOF: ipc4: Stop using the query_fw_configuration fw_loader ops
ASoC: SOF: loader: Remove the query_fw_configuration ops
ASoC: SOF: ipc4-loader: Support for loading external libraries

Ranjani Sridharan (1):
ASoC: SOF: loader: Set complete state before post_fw_run op

 include/sound/sof.h                  |  10 +-
 include/sound/sof/ipc4/header.h      |   4 +
 sound/soc/sof/amd/acp-loader.c       |   6 +-
 sound/soc/sof/intel/apl.c            |   3 +
 sound/soc/sof/intel/cnl.c            |   3 +
 sound/soc/sof/intel/hda-loader-skl.c |   7 +-
 sound/soc/sof/intel/hda-loader.c     |  83 +++++++++-
 sound/soc/sof/intel/hda.h            |   4 +
 sound/soc/sof/intel/icl.c            |   3 +
 sound/soc/sof/intel/mtl.c            |   3 +
 sound/soc/sof/intel/pci-apl.c        |   6 +
 sound/soc/sof/intel/pci-cnl.c        |   9 ++
 sound/soc/sof/intel/pci-icl.c        |   6 +
 sound/soc/sof/intel/pci-mtl.c        |   3 +
 sound/soc/sof/intel/pci-tgl.c        |  24 +++
 sound/soc/sof/intel/tgl.c            |   3 +
 sound/soc/sof/ipc.c                  |   6 +
 sound/soc/sof/ipc3-loader.c          |  26 ++-
 sound/soc/sof/ipc4-loader.c          | 233 ++++++++++++++++++++++++---
 sound/soc/sof/ipc4-priv.h            |  65 ++++++--
 sound/soc/sof/ipc4-topology.c        |  17 +-
 sound/soc/sof/ipc4.c                 |  41 +++++
 sound/soc/sof/loader.c               |  25 ++-
 sound/soc/sof/sof-pci-dev.c          |  26 +++
 sound/soc/sof/sof-priv.h             |  27 +++-
 25 files changed, 543 insertions(+), 100 deletions(-)
Signature · 1 line
2.38.1