Skip to content

ASoC: SOF: Intel: Harden the IPC4 low level sequencing

Peter Ujfalusi alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ASoC: SOF: ipc4: Log the tx message before sending itsound/soc/sof/ipc4.c+2 -20 replies
2/4ASoC: SOF: Intel: ipc4: Read the interrupt reason registers at the same timesound/soc/sof/intel/cnl.c sound/soc/sof/intel/hda-ipc.c sound/soc/sof/intel/mtl.c+4 -30 replies
3/4ASoC: SOF: Intel: ipc4: Wait for channel to be free before sending a messagesound/soc/sof/intel/cnl.c sound/soc/sof/intel/hda-ipc.c sound/soc/sof/intel/hda.c +2 more+71 -00 replies
4/4ASoC: SOF: Intel: ipc4: Ack a received reply or notification separatelysound/soc/sof/intel/cnl.c sound/soc/sof/intel/hda-ipc.c sound/soc/sof/intel/mtl.c+11 -80 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchKai VehmanenPierre-Louis BossartRanjani SridharanRander Wang
1/4R-b R-b R-b R-b
2/4R-b R-b R-b R-b
3/4R-b R-b R-b R-b
4/4R-b R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] ASoC: SOF: Intel: Harden the IPC4 low level sequencing

Hi,

The IPC4 use of doorbell registers leaves some corner cases not well defined and the 'correct sequences' are subjective in a sense.
The DSP doorbell registers are used as separate and independent channels and the sequences for host -> DSP -> host (reply) can be racy.

For example:
The ACKing of a received message can happen before the firmware sends the reply or it can as well happen after the reply has been sent and received by the host. Both can be considered 'correct sequences' but they need different handling.

This series will allow the kernel to service any interpretation of the sequencing on the firmware side.

Regards,
Peter
---
Peter Ujfalusi (4):
ASoC: SOF: ipc4: Log the tx message before sending it
ASoC: SOF: Intel: ipc4: Read the interrupt reason registers at the
same time
ASoC: SOF: Intel: ipc4: Wait for channel to be free before sending a
message
ASoC: SOF: Intel: ipc4: Ack a received reply or notification
separately

 sound/soc/sof/intel/cnl.c     | 26 ++++++++++++++++++++++----
 sound/soc/sof/intel/hda-ipc.c | 27 +++++++++++++++++++++++----
 sound/soc/sof/intel/hda.c     | 11 +++++++++++
 sound/soc/sof/intel/hda.h     |  9 +++++++++
 sound/soc/sof/intel/mtl.c     | 24 +++++++++++++++++++++---
 sound/soc/sof/ipc4.c          |  4 ++--
 6 files changed, 88 insertions(+), 13 deletions(-)
Signature · 1 line
2.38.0