Skip to content

libtraceevent: Handling cpumask event fields

Valentin Schneider linux-trace-devel 3 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 0 repliesNew
  2. v22 patches 4 repliesSuperseded
  3. v12 patches 4 repliesSuperseded

Changes in v3 from the cover letter

++++++++
o Rebased on top of latest libtraceevent
o Added unit tests (Steven)
o Moved TEP_PRINT_CPUMASK definition to the tail of tep_print_arg_type (Steven)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4libtraceevent: Ensure print_field_raw() terminates with '\0'src/event-parse.c+1 -00 replies
2/4libtraceevent: Add boiler-plate code for cpumask typesinclude/traceevent/event-parse.h src/event-parse.c+25 -00 replies
3/4libtraceevent: Pretty-print cpumask fields as a cpulistsrc/event-parse.c+167 -10 replies
4/4libtraceevent: Add unit tests for cpumask processingutest/traceevent-utest.c+161 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/4] libtraceevent: Handling cpumask event fields

Hi folks,

While discussing around [1], Steve had the idea [2] of creating a "proper" type for cpumask event fields so that userspace tooling doesn't have to guess whether an unsigned long [] is meant to be a cpumask or not.

o Patch 1 is a collateral fix found by running the new units tests.
o Patch 2 introduces a small amount of boiler plate to get cpumask fields on the same level as bitmask fields
o Patch 3 adds pretty-print output for cpumasks
o Patch 4 is unit tests for the above

Cheers,
Valentin

Revisions
=========

v2 -> v3
++++++++
o Rebased on top of latest libtraceevent
o Added unit tests (Steven)
o Moved TEP_PRINT_CPUMASK definition to the tail of tep_print_arg_type (Steven)

v1 -> v2
++++++++
o Rebased on top of latest libtraceevent
o Fixed s/__get_cpumask/__get_rel_cpumask/ typo

[1]: http://lore.kernel.org/r/[email protected]
[2]: http://lore.kernel.org/r/[email protected]

Valentin Schneider (4):
libtraceevent: Ensure print_field_raw() terminates with '\0'
libtraceevent: Add boiler-plate code for cpumask types
libtraceevent: Pretty-print cpumask fields as a cpulist
libtraceevent: Add unit tests for cpumask processing

 include/traceevent/event-parse.h |   1 +
 src/event-parse.c                | 191 +++++++++++++++++++++++++++++++
 utest/traceevent-utest.c         | 161 ++++++++++++++++++++++++++
 3 files changed, 353 insertions(+)

--
2.31.1