Skip to content

Hugetlb:Migrating the libhugetlbfs tests

Tarun Sahu ltp 11 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 posting 2/27 patches 5 repliesIn review
  2. v4 posting 2/27 patches 7 repliesSuperseded
  3. v3 posting 2/27 patches 1 replySuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v8 Latest4 patches4 repliesIn review
v74 patches5 repliesSuperseded
v64 patches6 repliesSuperseded
v5 posting 1/24 patches4 repliesSuperseded
v4 posting 1/24 patches0 repliesSuperseded
v3 posting 1/24 patches11 repliesSuperseded
v23 patches7 repliesSuperseded
v13 patches0 repliesSuperseded

Changes in v8 from the cover letter

1. Updated the check for mmu_type for powerpc in PATCH[2/4].
2. Removed leftover in test description.

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Hugetlb: Add new tst_test options for hugeltb test supportinclude/tst_hugepage.h include/tst_test.h lib/tst_test.c+46 -30 replies
2/4Hugetlb: Migrating libhugetlbfs brk_near_hugeruntest/hugetlb testcases/kernel/mem/.gitignore testcases/kernel/mem/hugetlb/hugemmap/hugemmap07.c +1 more+137 -01 reply
3/4Hugetlb: Migrating libhugetlbfs chunk-overcommitruntest/hugetlb testcases/kernel/mem/.gitignore testcases/kernel/mem/hugetlb/hugemmap/hugemmap08.c+146 -01 reply
4/4Hugetlb: Migrating libhugetlbfs corrupt-by-cow-optruntest/hugetlb testcases/kernel/mem/.gitignore testcases/kernel/mem/hugetlb/hugemmap/hugemmap09.c+81 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchLi WangCyril Hrubis
1/4R-b R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [LTP] [PATCH v8 0/4] Hugetlb:Migrating the libhugetlbfs tests

Hi,
Libhugetlbfs is not being maintained actively, and some distro is dropping support for it. There are some tests that are good for testing hugetlb functionality in kernel.

As per previous dicussion in RFC[1], Here, this patch series consists of hugetlb tests taken from libhugetlbfs modified to work in ltp environment.

Based on suggestion[2], I am reposting the patches again. Also, I added suggested changes at [3].

ref:
1:https://lore.kernel.org/all/[email protected]/ 2:https://lore.kernel.org/all/[email protected]/ 3:https://lore.kernel.org/all/[email protected]/

v1 -> v2
1. In (brk near huge) test [PATCH 1/3] removed unused library function test_addr_huge() and read_maps().
v2 -> v3
1. Added a new patch commit for two new flags "needs_hugetlbfs" & "needs_unlinked_hugetlb_file" in tst_test and modified tests to use these flags.
2. Added taint check in test [PATCH 1/3].
3. Removed redundant Hopt and nr_opt option.
4. Corrected pre-processor ARCH based conditional flags in test [PATCH 1/3]
v3 -> v4
1. Removed the needs_unlinked_hugetlb_file option in PATCH[1/4].
2. Removed the redundant saved_oc_hugepages checks in PATCH[3/4].
3. Updated the mntpoint checks in PATCH[1/4].
v4 -> v5
1. Removed the needs_hugetlbfs check from needs_tmpdir function, because mntpoint is now mandatory option with needs_hugetlbfs. (PATCH[1/4])
v5 -> v6
1. Edited the comment for needs_hugetlbfs PATCH[1/4].
2. Changed TCID to tid and removed __func__ from tst_brk PATCH[1/4].
3. Removed SAFE_UMOUNT in do_cleanup PATCH[1/4].
4. Added the ARCH definition in Makefile PATCH[2/4].
5. Removed ALIGN and use LTP_ALIGN PATCH[2/4].
v6 -> v7
1. Removed ppc32 check from makefile, and checked for ppc32 system at runtime in PATCH[2/4]
2. Updated the test description in PATCH[2,3,4/4].
3. Defined macros for Hugepage related strings.
v7 -> v8
1. Updated the check for mmu_type for powerpc in PATCH[2/4].
2. Removed leftover in test description.

Tarun Sahu (4):
Hugetlb: Add new tst_test options for hugeltb test support
Hugetlb: Migrating libhugetlbfs brk_near_huge
Hugetlb: Migrating libhugetlbfs chunk-overcommit
Hugetlb: Migrating libhugetlbfs corrupt-by-cow-opt

 include/tst_hugepage.h                        |   7 +
 include/tst_test.h                            |  10 ++
 lib/tst_test.c                                |  32 +++-
 runtest/hugetlb                               |   3 +
 testcases/kernel/mem/.gitignore               |   3 +
 .../kernel/mem/hugetlb/hugemmap/hugemmap07.c  | 133 ++++++++++++++++
 .../kernel/mem/hugetlb/hugemmap/hugemmap08.c  | 144 ++++++++++++++++++
 .../kernel/mem/hugetlb/hugemmap/hugemmap09.c  |  79 ++++++++++
 testcases/kernel/mem/hugetlb/lib/hugetlb.h    |   2 +
 9 files changed, 410 insertions(+), 3 deletions(-)
 create mode 100644 testcases/kernel/mem/hugetlb/hugemmap/hugemmap07.c
 create mode 100644 testcases/kernel/mem/hugetlb/hugemmap/hugemmap08.c
 create mode 100644 testcases/kernel/mem/hugetlb/hugemmap/hugemmap09.c
Signature · 5 lines
2.31.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp