Skip to content

PCI: Remove unnecessary <linux/of_irq.h> includes

Bjorn Helgaas linux-arm-kernel linux-omap linux-pci linux-riscv linux-rockchip linux-tegra linuxppc-dev lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 3 repliesIn review
  2. v24 patches 2 repliesSuperseded
  3. v11 patch 11 repliesSuperseded

Changes in v3 from the cover letter

- Include <linux/irqdomain.h> explicitly in xgene-msi, which doesn't need <linux/of_irq.h> itself, but relied on it to include <linux/irqdomain.h>. On x86, this was covered up by the fact that <linux/msi.h> includes <asm/msi.h>, which includes <asm/irqdomain.h>, which includes <linux/irqdomain.h>. But on parisc, <asm/msi.h> is actually asm-generic/msi.h, which does *not* include <linux/irqdomain.h>
- Pick up tags from Conor Dooley and Thomas Petazzoni

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5PCI: altera-msi: Include <linux/irqdomain.h> explicitlydrivers/pci/controller/pcie-altera-msi.c+1 -00 replies
2/5PCI: microchip: Include <linux/irqdomain.h> explicitlydrivers/pci/controller/pcie-microchip-host.c+1 -00 replies
3/5PCI: mvebu: Include <linux/irqdomain.h> explicitlydrivers/pci/controller/pci-mvebu.c+1 -00 replies
4/5PCI: xgene-msi: Include <linux/irqdomain.h> explicitlydrivers/pci/controller/pci-xgene-msi.c+1 -00 replies
5/5PCI: Remove unnecessary <linux/of_irq.h> includesdrivers/pci/controller/cadence/pci-j721e.c drivers/pci/controller/dwc/pci-layerscape.c drivers/pci/controller/dwc/pcie-armada8k.c +11 more+0 -141 reply

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchConor DooleyThomas PetazzoniRoy Zang
1/5
2/5R-b
3/5A-b
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] PCI: Remove unnecessary <linux/of_irq.h> includes

From: Bjorn Helgaas <[email protected]>

Many host controller drivers #include <linux/of_irq.h> even though they don't need it. Remove the unnecessary #includes.

v2: https://lore.kernel.org/r/[email protected]/
v1: https://lore.kernel.org/r/[email protected]/

Changes from v2 to v3:
- Include <linux/irqdomain.h> explicitly in xgene-msi, which doesn't need <linux/of_irq.h> itself, but relied on it to include <linux/irqdomain.h>. On x86, this was covered up by the fact that <linux/msi.h> includes <asm/msi.h>, which includes <asm/irqdomain.h>, which includes <linux/irqdomain.h>. But on parisc, <asm/msi.h> is actually asm-generic/msi.h, which does *not* include <linux/irqdomain.h>
- Pick up tags from Conor Dooley and Thomas Petazzoni

Changes from v1 to v2:
- Include <linux/irqdomain.h> explicitly in altera-msi and microchip, which don't need <linux/of_irq.h> itself, but relied on it to include <linux/irqdomain.h>
- Include <linux/irqdomain.h> explicitly in mvebu, which needs both it and <linux/of_irq.h>

Bjorn Helgaas (5):
PCI: altera-msi: Include <linux/irqdomain.h> explicitly
PCI: microchip: Include <linux/irqdomain.h> explicitly
PCI: mvebu: Include <linux/irqdomain.h> explicitly
PCI: xgene-msi: Include <linux/irqdomain.h> explicitly
PCI: Remove unnecessary <linux/of_irq.h> includes

 drivers/pci/controller/cadence/pci-j721e.c   | 1 -
 drivers/pci/controller/dwc/pci-layerscape.c  | 1 -
 drivers/pci/controller/dwc/pcie-armada8k.c   | 1 -
 drivers/pci/controller/dwc/pcie-tegra194.c   | 1 -
 drivers/pci/controller/pci-mvebu.c           | 1 +
 drivers/pci/controller/pci-v3-semi.c         | 1 -
 drivers/pci/controller/pci-xgene-msi.c       | 2 +-
 drivers/pci/controller/pci-xgene.c           | 1 -
 drivers/pci/controller/pcie-altera-msi.c     | 2 +-
 drivers/pci/controller/pcie-iproc-platform.c | 1 -
 drivers/pci/controller/pcie-iproc.c          | 1 -
 drivers/pci/controller/pcie-microchip-host.c | 2 +-
 drivers/pci/controller/pcie-rockchip-host.c  | 1 -
 drivers/pci/controller/pcie-xilinx-cpm.c     | 1 -
 drivers/pci/controller/pcie-xilinx-nwl.c     | 1 -
 15 files changed, 4 insertions(+), 14 deletions(-)
Signature · 1 line
2.25.1