Skip to content

PCI/portdrv: Squash into portdrv.c

Bjorn Helgaas linux-pci lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3PCI/portdrv: Squash into portdrv.cdrivers/pci/pcie/Makefile drivers/pci/pcie/portdrv.c drivers/pci/pcie/portdrv.h +1 more+244 -2721 reply
2/3PCI/portdrv: Move private things to portdrv.cdrivers/pci/pcie/portdrv.c drivers/pci/pcie/portdrv.h+9 -91 reply
3/3PCI/portdrv: Unexport pcie_port_service_register(), pcie_port_service_unregister()drivers/pci/pcie/portdrv.c+0 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKeith BuschChristoph Hellwig
SeriesR-b
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] PCI/portdrv: Squash into portdrv.c

From: Bjorn Helgaas <[email protected]>

The PCIe portdrv is split across portdrv_core.c and portdrv_pci.c, but neither is very big and it's a hassle to figure out which to look at.

Squash them into a single portdrv.c file. Make functions static and non-exported when possible, and move some private things out of portdrv.h.

Please comment.

Bjorn Helgaas (3):
PCI/portdrv: Squash into portdrv.c PCI/portdrv: Move private things to portdrv.c PCI/portdrv: Unexport pcie_port_service_register(),
pcie_port_service_unregister()

 drivers/pci/pcie/Makefile                     |   2 +-
 .../pci/pcie/{portdrv_core.c => portdrv.c}    | 263 +++++++++++++++++-
 drivers/pci/pcie/portdrv.h                    |  19 --
 drivers/pci/pcie/portdrv_pci.c                | 252 -----------------
 4 files changed, 253 insertions(+), 283 deletions(-)
 rename drivers/pci/pcie/{portdrv_core.c => portdrv.c} (69%)
 delete mode 100644 drivers/pci/pcie/portdrv_pci.c
Signature · 1 line
2.25.1