Skip to content

Clean up clang `-Wshorten-64-to-32` warnings

Ammar Faizi io-uring 2 versions Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyApplied
  2. v13 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Fix Signed-off-by tag.
- Make the cast in patch #1 consistent.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3liburing: Clean up `-Wshorten-64-to-32` warnings from clangsrc/arch/syscall-defs.h src/register.c src/setup.c +1 more+14 -110 replies
2/3Makefile: Introduce `LIBURING_CFLAGS` variablesrc/Makefile+4 -10 replies
3/3github: Append `-Wshorten-64-to-32` flag for clang build.github/workflows/build.yml+4 -00 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchAmmar Faizi
1/3Co-authored-by
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH liburing v2 0/3] Clean up clang `-Wshorten-64-to-32` warnings

From: Ammar Faizi <[email protected]>

Hi Jens,

This is a v2.

v2:
- Fix Signed-off-by tag.
- Make the cast in patch #1 consistent.

Please consider this small cleanup series before the release.

This series is a follow up of the clean up -Wshorten-64-to-32 warnings that I discussed with Dylan previously. It only addresses the warnings in the src/ dir (main library). We ignore the tests for now.

-Wshorten-64-to-32 is a clang-specific flag, it currently doesn't exist in GCC.

There are 3 patches in this series:

- Patch 1 is to clean up the warnings in the main library (this is based on a patch from Dylan).

Taken from: https://github.com/DylanZA/liburing/commit/cdd6dfbb9019.patch

- Patch 2 is to introduce LIBURING_CFLAGS variable in the Makefile. We need this varaible to apply specific compiler flags to the main library only. Currently, this flag is only used by the GitHub bot.

- Patch 3 is to integrate -Wshorten-64-to-32 flag to the GitHub bot.

---

Ammar Faizi (2):
Makefile: Introduce LIBURING_CFLAGS variable
github: Append -Wshorten-64-to-32 flag for clang build

Dylan Yudaken (1):
liburing: Clean up -Wshorten-64-to-32 warnings from clang

 .github/workflows/build.yml |  4 ++++
 src/Makefile                |  5 ++++-
 src/arch/syscall-defs.h     |  4 ++--
 src/register.c              |  5 ++++-
 src/setup.c                 | 12 ++++++------
 src/syscall.h               |  4 ++--
 6 files changed, 22 insertions(+), 12 deletions(-)

base-commit: 3049530665ba6464f3c5f6f80b28e965719ca602

Signature · 1 line
Ammar Faizi