perf test: Improve perf record tests (v2)
Status from this message: Thanks, applied to perf/core.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | perf test: Do not use instructions:u explicitlytools/ | +5 | 1 reply | |
| 2/8 | perf test: Fix shellcheck issues in the record testtools/ | +9 | 2 replies | |
| 3/8 | perf test: Use a test program in perf record teststools/ | +60 | 9 replies | |
| 4/8 | perf test: Wait for a new thread when testing --per-thread recordtools/ | +27 | 2 replies | |
| 5/8 | perf test: Add system-wide mode in perf record teststools/ | +21 | 2 replies | |
| 6/8 | perf test: Add target workload test in perf record teststools/ | +18 | 2 replies | |
| 7/8 | perf test: Test record with --threads optiontools/ | +28 | 2 replies | |
| 8/8 | perf test: Do not set TEST_SKIP for record subteststools/ | +0 | 2 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Adrian Hunter | Ian Rogers |
|---|---|---|
| 1/8 | R-b | A-b |
| 2/8 | R-b | A-b |
| 3/8 | R-b | A-b |
| 4/8 | R-b | A-b |
| 5/8 | R-b | A-b |
| 6/8 | R-b | A-b |
| 7/8 | R-b | A-b |
| 8/8 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHSET 0/8] perf test: Improve perf record tests (v2)
Hello,
This patchset improves the perf record tests to check more cases so that it can find problems early. The motivation was a failure per-thread mmap with multi-threaded targets which Adrian is working on the fix.
Changes in v2)
* fix shellcheck issues
* drop unsupported --per-thread and --threads combination
* do not use initial delay (-D option); instead it runs the target and wait for it separately using the recent waiting.sh library
* add Adrian's Reviewed-by tags
I added a custom test program and more combinations like system-wide and command line workload (in per-process mode) testing with multi-threaded recording mode.
Currently it succeeds every tests when running as root!
$ sudo ./perf test -v 91 91: perf record tests : --- start --- test child forked, pid 108975 Build a test program Basic --per-thread mode test Basic --per-thread mode test [Success] Register capture test Register capture test [Success] Basic --system-wide mode test Basic --system-wide mode test [Success] Basic target workload test Basic target workload test [Success] test child finished with 0 ---- end ---- perf record tests: Ok
You can find it in 'perf/record-test-v2' branch in
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks,
Namhyung
Namhyung Kim (8):
perf test: Do not use instructions:u explicitly
perf test: Fix shellcheck issues in the record test perf test: Use a test program in perf record tests perf test: Wait for a new thread when testing --per-thread record perf test: Add system-wide mode in perf record tests perf test: Add target workload test in perf record tests perf test: Test record with --threads option
perf test: Do not set TEST_SKIP for record subtests
tools/perf/tests/shell/record.sh | 180 +++++++++++++++++++++++++++---- 1 file changed, 158 insertions(+), 22 deletions(-)
base-commit: a3a365655a28f12f07eddf4f3fd596987b175e1d
Signature · 1 line
2.38.0.135.g90850a2211-goog