Skip to content

drm/amd/display: add DCN support for ARM64

Ao Zhong amd-gfx linux-arm-kernel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest1 patch 4 repliesIn review
  2. v31 patch 7 repliesSuperseded
  3. v21 patch 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v1 posting 2/21 patch15 repliesSuperseded
v1 posting 1/21 patch1 replySuperseded

Changes in v4 from the cover letter

- Check if CC_IS_CLANG is disabled, since current DCN build with clang on ARM64 is broken

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1drm/amd/display: add DCN support for ARM64drivers/gpu/drm/amd/display/Kconfig drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c drivers/gpu/drm/amd/display/dc/dml/Makefile+24 -54 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchRodrigo Siqueira
1/1R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/1] drm/amd/display: add DCN support for ARM64

Hello everyone,

Recently I got a SBSA ARM64 workstation, and try to use it as my daily drive machine after installing an AMD RX6400 graphics card.

Since the newer AMD GPUs require DCN (Display Core Next) support to work properly, DCN is not supported on ARM64 platforms. Because some code in DCN needs to use FPU, and aarch64 has no soft floating-point toolchain.

Displaycore developers have started isolating code that needs to use FPU, and most of the code has been isolated. In the process of trying to enable DCN support for the ARM64 platform, I found that there are two remaining code blocks that are not isolated. Due to -mgeneral-regs-only is enabled by default to compile the kernel on the ARM64 platform, these two code blocks will cause the compilation to fail after enabling DCN support.

I have submitted two patches to isolate the remaining two code blocks that need to use the FPU.
Links: https://patchwork.freedesktop.org/patch/508813/
Links: https://patchwork.freedesktop.org/patch/508816/
After merging these two patches, we can enable DCN support for ARM64 platform.

I removed -mgeneral-regs-only CFLAG in the dml/Makefile for the code that needs to use hardware FPU, and add a control mechanism in amdgpu_dm/dc_fpu.c for ARM Neon.

Change Since V3:
- Check if CC_IS_CLANG is disabled, since current DCN build with clang on ARM64 is broken

Change Since V2:
- Drop CONFIG_DRM_AMD_DC_DCN check when initializing the dml_rcflags for ARM64
- Drop CONFIG_ARM64 and CONFIG_DRM_AMD_DC_DCN check for the per-file cflags list entirely

Change Since V1:
- replace $(dml_rcflags_arm64) with $(dml_rcflags) in dml/Makefile

Ao Zhong (1):
drm/amd/display: add DCN support for ARM64

 drivers/gpu/drm/amd/display/Kconfig           |  3 ++-
 .../gpu/drm/amd/display/amdgpu_dm/dc_fpu.c    |  6 ++++++
 drivers/gpu/drm/amd/display/dc/dml/Makefile   | 20 +++++++++++++++----
 3 files changed, 24 insertions(+), 5 deletions(-)
Signature · 1 line
2.37.4