Skip to content

RISC-V: Ensure Zicbom has a valid block size

Andrew Jones linux-riscv 3 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 8 repliesApplied 3/3
  2. v23 patches 5 repliesSuperseded
  3. v13 patches 9 repliesSuperseded

Changes in v3 from the cover letter

- Mostly just a friendly ping, but also rebased and picked up r-b's

Patches in v3 All 3 applied

#Subject and filesSizeRepliesApplied
1/3RISC-V: Improve use of isa2hwcap[]arch/riscv/kernel/cpufeature.c+11 -90 repliesApplied
2/3RISC-V: Introduce riscv_isa_extension_checkarch/riscv/kernel/cpufeature.c+11 -30 repliesApplied
3/3RISC-V: Ensure Zicbom has a valid block sizearch/riscv/kernel/cpufeature.c+13 -07 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchConor DooleyHeiko Stuebner
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] RISC-V: Ensure Zicbom has a valid block size

When a DT puts zicbom in the isa string, but does not provide a block size, ALT_CMO_OP() will attempt to do cache operations on address zero since the start address will be ANDed with zero. We can't simply BUG() in riscv_init_cbom_blocksize() when we fail to find a block size because the failure will happen before logging works, leaving users to scratch their heads as to why the boot hung. Instead, ensure Zicbom is disabled and output an error which will hopefully alert people that the DT needs to be fixed. While at it, add a check that the block size is a power-of-2 too.

The first patch of the series is a cleanup of code that crossed the path of this work. The second patch prepares for isa ext. checking and the third finally does what this cover letter says.

Thanks,
drew

v3:
- Mostly just a friendly ping, but also rebased and picked up r-b's

v2:
- Unconditionally complain when we detect a problem with DT's cbom-block-size
- A couple r-b's from Conor

Andrew Jones (3):
RISC-V: Improve use of isa2hwcap[]
RISC-V: Introduce riscv_isa_extension_check
RISC-V: Ensure Zicbom has a valid block size

 arch/riscv/kernel/cpufeature.c | 43 ++++++++++++++++++++++++++--------
 1 file changed, 33 insertions(+), 10 deletions(-)
Signature · 7 lines
2.38.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv