Skip to content

fix FIO_OPT_STR_SET and update io_uring doc

Ankit Kumar fio 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2parse: set min and max limit for FIO_OPT_STR_SETparse.c+1 -10 replies
2/2io_uring: update documentation and small fix for sqthread_pollHOWTO.rst engines/io_uring.c fio.1+7 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] fix FIO_OPT_STR_SET and update io_uring doc

This series has 2 small patches.

First patch deals with type FIO_OPT_STR_SET.

FIO_OPT_STR_SET suggests the passed value should be empty or boolean value ([0|1]).
But for the given type it accepts any integer value as there is no limit for min and max values. Add a limit for that during the option initialization.

Note: With this the existing job files, test scripts which used to pass any integer value will not work.

Other way to fix this would be to update the typehelp for FIO_OPT_STR_SET as "empty or integer value (opt=100)"

Second patch sets the type for sqthread_poll to FIO_OPT_STR_SET instead of FIO_OPT_INT. This I believe is what was originally intended when the option was added.
This patch also adds the missing types for io_uring options in the documentation.

This now fixes the issue:
https://github.com/axboe/fio/issues/927

Ankit Kumar (2):
parse: set min and max limit for FIO_OPT_STR_SET
io_uring: update documentation and small fix for sqthread_poll

 HOWTO.rst          | 6 +++---
 engines/io_uring.c | 2 +-
 fio.1              | 6 +++---
 parse.c            | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)
Signature · 1 line
2.17.1