Skip to content

net: ipqess: introduce Qualcomm IPQESS driver

Maxime Chevallier linux-arm-kernel linux-devicetree lkml netdev oe-kbuild-all 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 13 repliesIn review
  2. v75 patches 8 repliesSuperseded
  3. v65 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v55 patches11 repliesSuperseded

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controllerDocumentation/devicetree/bindings/net/qcom,ipq4019-ess-edma.yaml+94 -00 replies
2/5net: ipqess: introduce the Qualcomm IPQESS driverMAINTAINERS drivers/net/ethernet/qualcomm/Kconfig drivers/net/ethernet/qualcomm/Makefile +4 more+1956 -00 replies
3/5net: dsa: add out-of-band tagging protocolDocumentation/networking/dsa/dsa.rst MAINTAINERS include/linux/dsa/oob.h +6 more+103 -113 replies
4/5net: ipqess: Add out-of-band DSA tagging supportdrivers/net/ethernet/qualcomm/Kconfig drivers/net/ethernet/qualcomm/ipqess/ipqess.c drivers/net/ethernet/qualcomm/ipqess/ipqess.h+68 -10 replies
5/5ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet controllerarch/arm/boot/dts/qcom-ipq4019.dtsi+48 -00 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchKrzysztof Kozlowski
1/5R-b
2/5
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH net-next v8 0/5] net: ipqess: introduce Qualcomm IPQESS driver

Hello everyone,

This is the 8th iteration on the IPQESS driver, that includes a new DSA tagger to let the MAC convey the tag to the switch through an out-of-band medium, here using DMA descriptors.

Notables changes on v8 :
- Added fixed-link in the dtsi SoC file
- Removed the ethernet0 alias from the dtsi
- Added a missing blank line in tagger driver

Notables changes on V7 :
- Fixed sparse warnings
- Fixed a typo in the bindings
- Added missing maintainers in CC

Notables changes on V6 :
- Cleanup unused helpers and fields in the tagger
- Cleanup ordering in various files
- Added more documentation on the tagger
- Fixed the CHANGEUPPER caching
- Cleanups in the IPQESS driver

Notables changes on V5 :
- Fix caching of CHANGEUPPER events
- Use a skb extension-based tagger
- Rename the binding file
- Some cleanups in the ipqess driver itself

Notables changes on V4 :
- Cache the uses_dsa info from CHANGEUPPER events
- Use better string handling helpers for ethtool stats
- rename ethtool callbacks
- Fix a binding typo

Notables changes on V3 :
- Took into account Russell's review on the ioctl handler and the mac capabilities that were missing
- Took Andrew's reviews into account by reworking the napi rx loop, some stray "inline" keywords, and useless warnings
- Took Vlad's reviews into account by reworking a few macros
- Took Christophe's review into account by removing extra GFP_ZERO
- Took Rob's review into account by simplifying the binding

Notables changes on V2 :
- Put the DSA tag in the skb itself instead of using skb->shinfo
- Fixed the initialisation sequence based on Andrew's comments
- Reworked the error paths in the init sequence
- Add support for the clock and reset lines on that controller
- Fixed and updated the binding

The driver itself is pretty straightforward, but has lived out-of-tree for a while. I've done my best to clean-up some outdated API calls, but some might remain.

This controller is somewhat special, since it's part of the IPQ4019 SoC which also includes an QCA8K switch, and uses the IPQESS controller for the CPU port. The switch is so tightly intergrated with the MAC that it is connected to the MAC using an internal link (hence the fact that we only support PHY_INTERFACE_MODE_INTERNAL), and this has some consequences on the DSA side.

The tagging for the switch isn't done inband as most switch do, but out-of-band, the DSA tag being included in the DMA descriptor.

This series includes a new out-of-band tagger that uses skb extensions to convey the tag between the tagger and the MAC driver.

Thanks to the Sartura folks who worked on a base version of this driver, and provided test hardware.

Best regards,

Maxime

Maxime Chevallier (5):
net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller
net: ipqess: introduce the Qualcomm IPQESS driver
net: dsa: add out-of-band tagging protocol
net: ipqess: Add out-of-band DSA tagging support
ARM: dts: qcom: ipq4019: Add description for the IPQESS Ethernet
controller

 .../bindings/net/qcom,ipq4019-ess-edma.yaml   |   94 ++
 Documentation/networking/dsa/dsa.rst          |   13 +-
 MAINTAINERS                                   |    8 +
 arch/arm/boot/dts/qcom-ipq4019.dtsi           |   48 +
 drivers/net/ethernet/qualcomm/Kconfig         |   12 +
 drivers/net/ethernet/qualcomm/Makefile        |    2 +
 drivers/net/ethernet/qualcomm/ipqess/Makefile |    8 +
 drivers/net/ethernet/qualcomm/ipqess/ipqess.c | 1308 +++++++++++++++++
 drivers/net/ethernet/qualcomm/ipqess/ipqess.h |  522 +++++++
 .../ethernet/qualcomm/ipqess/ipqess_ethtool.c |  164 +++
 include/linux/dsa/oob.h                       |   16 +
 include/linux/skbuff.h                        |    3 +
 include/net/dsa.h                             |    2 +
 net/core/skbuff.c                             |   10 +
 net/dsa/Kconfig                               |    9 +
 net/dsa/Makefile                              |    1 +
 net/dsa/tag_oob.c                             |   49 +
 17 files changed, 2268 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq4019-ess-edma.yaml
 create mode 100644 drivers/net/ethernet/qualcomm/ipqess/Makefile
 create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess.c
 create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess.h
 create mode 100644 drivers/net/ethernet/qualcomm/ipqess/ipqess_ethtool.c
 create mode 100644 include/linux/dsa/oob.h
 create mode 100644 net/dsa/tag_oob.c
Signature · 1 line
2.37.3