Skip to content

Regset cleanups

Rick Edgecombe lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2x86: Separate out x86_regset for 32 and 64 bitarch/x86/kernel/ptrace.c+43 -241 reply
2/2x86: Improve formatting of user_regset arraysarch/x86/kernel/ptrace.c+65 -421 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchKees Cook
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Regset cleanups

These two cleanups came out of the shadow stack series[0]. Resending them separately for earlier consideration. They were also posted as separate cleanups once before[1]. Note, Eric Biederman had suggested to change the pre-existing format of REGSET_FOO32 to REGSET32_FOO. This was missed in an earlier revision, and the changes are now added in this version.

There should be no functional change. To verify this, testing included checking for binary differences in ptrace.o by:
1. Have the config be a 64 bit kernel with CONFIG_IA32_EMULATION=y
2. Adjust stock v6.1-rc1 and these changes to have the same line numbers for the bulk of the code in ptrace.c by adding blank lines.
3. Remove BUILD_BUG_ONs() from new changes.
4. strip and objdump both versions.
5. Compare and find disassembly was identical.

[0] https://lore.kernel.org/lkml/[email protected]/
[1] https://lore.kernel.org/lkml/[email protected]/

Rick Edgecombe (2):
x86: Separate out x86_regset for 32 and 64 bit
x86: Improve formatting of user_regset arrays

 arch/x86/kernel/ptrace.c | 174 ++++++++++++++++++++++++---------------
 1 file changed, 108 insertions(+), 66 deletions(-)

base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780

Signature · 1 line
2.17.1