Skip to content

Refactor __kmem_cache_create() and fix memory leak

Liu Shixin linux-mm lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 9 repliesIn review
  2. v33 patches 1 replySuperseded
  3. v23 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches0 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3mm/slab_common: Move cache_name to create_cache()mm/slab_common.c+14 -200 replies
2/3mm/slub: Refactor __kmem_cache_create()include/linux/slub_def.h mm/slab_common.c mm/slub.c+30 -370 replies
3/3mm/slub: Fix memory leak of kobj->name in sysfs_slab_add()include/linux/slub_def.h mm/slab_common.c mm/slub.c+21 -109 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] Refactor __kmem_cache_create() and fix memory leak

I found a memory leak of kobj->name in sysfs_slab_add() which is introduced by 80da026a8e5d ("mm/slub: fix slab double-free in case of duplicate sysfs filename"). Following the rules stated in the comment for kobject_init_and_add():

If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object.

We should use kobject_put() to free kobject.

But we can't simply add kobject_put() since it will free kmem_cache too. If we use kobject_put(), we need to skip other release functions.

In this series, We refactor the code to separate sysfs_slab_add() and debugfs_slab_add() from __kmem_cache_create(), and then use kobject_put() to free kobject in sysfs_slab_add(). This can fix the memory leak of kobject->name.

v1->v2: Fix build error reported by kernel test robot <[email protected]>. v2->v3: Don't free kmem_cache that create early.
v3->v4: Fix error in kfree_const of kobject's name.

Liu Shixin (3):
mm/slab_common: Move cache_name to create_cache() mm/slub: Refactor __kmem_cache_create()
mm/slub: Fix memory leak of kobj->name in sysfs_slab_add()

 include/linux/slub_def.h | 11 +++++++
 mm/slab_common.c         | 44 +++++++++++++++-------------
 mm/slub.c                | 63 +++++++++++++++-------------------------
 3 files changed, 58 insertions(+), 60 deletions(-)

--
2.25.1