Skip to content

mlx5: fix miss NULL check in devargs parsing

Michael Baum dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2common/mlx5: fix miss null check in devargs parsingdrivers/common/mlx5/mlx5_common.c+5 -30 replies
2/2net/mlx5: fix miss null check in ETH devargs parsingdrivers/net/mlx5/linux/mlx5_os.c+1 -10 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMatan Azrad
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] mlx5: fix miss NULL check in devargs parsing

The MLX5 PMD parses the devargs in several places.
It gets structure called "devargs" as a member of EAL device containing all needed information.

When "devargs" structure is invalid, the PMD avoids parsing it. However, when it valid but its field "args" is invalid, the PMD tries to parse it and dereference to NULL pointer.

Those patches add checks to avoid these NULL dereferencing.

Michael Baum (2):
common/mlx5: fix miss null check in devargs parsing net/mlx5: fix miss null check in ETH devargs parsing

 drivers/common/mlx5/mlx5_common.c | 8 +++++---
 drivers/net/mlx5/linux/mlx5_os.c  | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)
Signature · 1 line
2.25.1