Skip to content

i915: CAGF and RC6 changes for MTL

Ashutosh Dixit dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

v4 from the cover letter

- Rebased
- Dropped "Use GEN12 RPSTAT register" patch from this series going to send separate series for it

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/i915/rps: Prefer REG_FIELD_GET in intel_rps_get_cagfdrivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c drivers/gpu/drm/i915/gt/intel_gt_regs.h drivers/gpu/drm/i915/gt/intel_rps.c+10 -150 replies
2/5drm/i915: Use GEN12_RPSTAT register for GT freqdrivers/gpu/drm/i915/gt/intel_gt_regs.h drivers/gpu/drm/i915/gt/intel_rps.c drivers/gpu/drm/i915/gt/intel_rps.h +1 more+32 -60 replies
3/5drm/i915/mtl: Modify CAGF functions for MTLdrivers/gpu/drm/i915/gt/intel_gt_regs.h drivers/gpu/drm/i915/gt/intel_rps.c+14 -20 replies
4/5drm/i915/gt: Use RC6 residency types as arguments to residency functionsdrivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c drivers/gpu/drm/i915/gt/intel_rc6.c +4 more+72 -600 replies
5/5drm/i915/mtl: C6 residency and C state type for MTL SAMediadrivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c drivers/gpu/drm/i915/gt/intel_gt_regs.h drivers/gpu/drm/i915/gt/intel_rc6.c+76 -50 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchRodrigo ViviAndi ShytiAshutosh Dixit
1/5R-b
2/5R-b R-b
3/5A-b R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/5] i915: CAGF and RC6 changes for MTL

This series includes the code changes to get CAGF, RC State and C6 Residency of MTL.

v3: Included "Use GEN12 RPSTAT register" patch

v4:
- Rebased
- Dropped "Use GEN12 RPSTAT register" patch from this series going to send separate series for it

v5:
- Included "drm/i915/gt: Change RC6 residency functions to accept register ID's" based on code review feedback

v6:
- Addressed Jani N's review comments on "drm/i915/gt: Change RC6 residency functions to accept register ID's"
- Re-add "drm/i915: Use GEN12_RPSTAT register for GT freq" to this series

v7: Rebuild, identical to v6

v8:
- Add "drm/i915/rps: Prefer REG_FIELD_GET in intel_rps_get_cagf" to the series (based on Rodrigo's review) to consistently use REG_FIELD_GET
- Minor changes to other patches, please see individual patches for changelogs

v9: Rebuild, identical to v8

v10: Address review comments from Rodrigo on Patch 5

v11: Change state name for MTL_CC0 to RC0 in Patch 5

Ashutosh Dixit (2):
drm/i915/rps: Prefer REG_FIELD_GET in intel_rps_get_cagf drm/i915/gt: Use RC6 residency types as arguments to residency
functions

Badal Nilawar (2):
drm/i915/mtl: Modify CAGF functions for MTL drm/i915/mtl: C6 residency and C state type for MTL SAMedia

Don Hiatt (1):
drm/i915: Use GEN12_RPSTAT register for GT freq

 drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 88 ++++++++++++++-----
 drivers/gpu/drm/i915/gt/intel_gt_regs.h       | 22 +++--
 drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c   | 12 +--
 drivers/gpu/drm/i915/gt/intel_rc6.c           | 64 +++++++++-----
 drivers/gpu/drm/i915/gt/intel_rc6.h           | 11 ++-
 drivers/gpu/drm/i915/gt/intel_rc6_types.h     | 15 +++-
 drivers/gpu/drm/i915/gt/intel_rps.c           | 51 ++++++++---
 drivers/gpu/drm/i915/gt/intel_rps.h           |  2 +
 drivers/gpu/drm/i915/gt/selftest_rc6.c        |  6 +-
 drivers/gpu/drm/i915/i915_pmu.c               |  9 +-
 10 files changed, 198 insertions(+), 82 deletions(-)
Signature · 1 line
2.38.0