Skip to content

RFC ibmveth: Implement BQL

Nick Child netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1ibmveth: Implement BQLdrivers/net/ethernet/ibm/ibmveth.c+7 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH net-next 0/1] ibmveth: Implement BQL

Hello,

Labeled as RFC because I am unsure if adding Byte Queue Limits (BQL) is positively effecting the ibmveth driver. BQL is common among network drivers so I would like to incorporate it into the virtual ethernet driver, ibmveth. But I am having trouble measuring its effects.

From my understanding (and please correct me if I am wrong), BQL will use the number of packets sent to the NIC to approximate the minimum number of packets to enqueue to a netdev_queue without starving the NIC. As a result, bufferbloat in the networking queues are minimized which may allow for smaller latencies.

After performing various netperf tests under differing loads and priorities, I do not see any performance effect when comparing the driver with and without BQL. The ibmveth driver is a virtual driver which has an abstracted view of the NIC so I am comfortable without seeing any performance deltas. That being said, I would like to know if BQL is actually being enforced in some way. In other words, I would like to observe a change in the number of queued bytes during BQL implementations. Does anyone know of a mechanism to measure the length of a netdev_queue?

I tried creating a BPF script[1] to track the bytes in a netdev_queue but again am not seeing any difference with and without BQL. I do not believe anything is wrong with BQL (it is more likely that my tracing is bad) but I would like to have some evidence of BQL having a positive effect on the device. Any recommendations or advice would be greatly appreciated.
Thanks.

[1] https://github.com/nick-child-ibm/bpf_scripts/blob/main/bpftrace_queued_bytes.bt

Nick Child (1):
ibmveth: Implement BQL

 drivers/net/ethernet/ibm/ibmveth.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Signature · 1 line
2.31.1