Skip to content

mm/damon/reclaim,lru_sort: enable/disable synchronously

SeongJae Park damon linux-kselftest linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] selftests-damon-add-tests-for-damon_lru_sorts-enabled-parameter.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesApplied 4/4

Patches in v1 All 4 applied

#Subject and filesSizeRepliesApplied
1/4mm/damon/reclaim: enable and disable synchronouslymm/damon/reclaim.c+23 -300 repliesApplied
2/4selftests/damon: add tests for DAMON_RECLAIM's enabled parametertools/testing/selftests/damon/Makefile tools/testing/selftests/damon/reclaim.sh+43 -00 repliesApplied
3/4mm/damon/lru_sort: enable and disable synchronouslymm/damon/lru_sort.c+22 -290 repliesApplied
4/4selftests/damon: add tests for DAMON_LRU_SORT's enabled parametertools/testing/selftests/damon/Makefile tools/testing/selftests/damon/lru_sort.sh+42 -10 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] mm/damon/reclaim,lru_sort: enable/disable synchronously

Writing a value to DAMON_RECLAIM and DAMON_LRU_SORT's 'enabled' parameters turns on or off DAMON in an ansychronous way. This means the parameter cannot be used to read the current status of them. 'kdamond_pid' parameter should be used instead for the purpose. The documentation is easy to be read as it works in a synchronous way, so it is a little bit confusing. It also makes the user space tooling dirty.

There's no real reason to have the asynchronous behavior, though. Simply make the parameter works synchronously, rather than updating the document.

The first and second patches changes the behavior of the 'enabled' parameter for DAMON_RECLAIM and adds a selftest for the changed behavior, respectively. Following two patches make the same changes for DAMON_LRU_SORT.

SeongJae Park (4):
mm/damon/reclaim: enable and disable synchronously selftests/damon: add tests for DAMON_RECLAIM's enabled parameter mm/damon/lru_sort: enable and disable synchronously selftests/damon: add tests for DAMON_LRU_SORT's enabled parameter

 mm/damon/lru_sort.c                       | 51 ++++++++++------------
 mm/damon/reclaim.c                        | 53 ++++++++++-------------
 tools/testing/selftests/damon/Makefile    |  1 +
 tools/testing/selftests/damon/lru_sort.sh | 41 ++++++++++++++++++
 tools/testing/selftests/damon/reclaim.sh  | 42 ++++++++++++++++++
 5 files changed, 129 insertions(+), 59 deletions(-)
 create mode 100755 tools/testing/selftests/damon/lru_sort.sh
 create mode 100755 tools/testing/selftests/damon/reclaim.sh
Signature · 1 line
2.25.1