Skip to content

hw/isa/piix4: Remove MIPS Malta specific bits

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 13 repliesIn review
  2. v13 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- bswap -> tswap (Bernhard)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/mips/malta: Introduce PIIX4_PCI_DEVFN definitionhw/mips/malta.c+3 -11 reply
2/3hw/mips/malta: Set PIIX4 IRQ routes in embedded bootloaderhw/mips/malta.c+19 -09 replies
3/3hw/isa/piix4: Correct IRQRC[A:D] reset valueshw/isa/piix4.c+4 -42 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchBernhard BeschowIgor Mammedov
1/3R-b
2/3
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] hw/isa/piix4: Remove MIPS Malta specific bits

Since v1:
- bswap -> tswap (Bernhard)

Bernhard posted a series merging both PIIX3/PIIX4 models in one [1]. Due to Malta-specific board code forced into the PIIX4 reset values, Bernhard had to include an array of "register values at reset" as a class property. This is not wrong, but to model properly the model, we should simply use the hardware real reset values, not try to bend the model to please the Malta board.

This series fix this issue by having the Malta bootloader code setting the board-specific PIIX4 IRQ routing values.

Note patch 2 still misses an equivalent nanoMIPS code.

Regards,

Phil.

[1] https://lore.kernel.org/qemu-devel/[email protected]/

Based-on: <[email protected]>
https://lore.kernel.org/qemu-devel/[email protected]/

Philippe Mathieu-Daudé (3):
hw/mips/malta: Introduce PIIX4_PCI_DEVFN definition hw/mips/malta: Set PIIX4 IRQ routes in embedded bootloader hw/isa/piix4: Correct IRQRC[A:D] reset values

 hw/isa/piix4.c  |  8 ++++----
 hw/mips/malta.c | 23 ++++++++++++++++++++++-
 2 files changed, 26 insertions(+), 5 deletions(-)
Signature · 1 line
2.37.3