Skip to content

xdp: hints via kfuncs

Stanislav Fomichev bpf netdev 10 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest17 patches 22 repliesIn review 2 of 17 applied
  2. v717 patches 25 repliesSuperseded
  3. v617 patches 12 repliesSuperseded
Earlier versions · 7
VersionPostedPatchesRepliesStatus
v517 patches20 repliesSuperseded
v415 patches29 repliesSuperseded
v3 posting 2/212 patches48 repliesSuperseded
v3 posting 1/211 patches7 repliesSuperseded
v2 posting 2/28 patches37 repliesSuperseded
v2 RFC posting 1/214 patches51 repliesSuperseded
v1 RFC5 patches44 repliesSuperseded

Patches in v8 2 of 17 applied

#Subject and filesSizeRepliesApplied
1/17bpf: Document XDP RX metadataDocumentation/networking/index.rst Documentation/networking/xdp-rx-metadata.rst+111 -00 replies
2/17bpf: Rename bpf_{prog,map}_is_dev_bound to is_offloadedinclude/linux/bpf.h kernel/bpf/core.c kernel/bpf/offload.c +4 more+31 -310 replies
3/17bpf: Move offload initialization into late_initcallkernel/bpf/offload.c+7 -150 replies
4/17bpf: Reshuffle some parts of bpf/offload.ckernel/bpf/offload.c+117 -1050 replies
5/17bpf: Introduce device-bound XDP programsdrivers/net/netdevsim/bpf.c include/linux/bpf.h include/uapi/linux/bpf.h +5 more+113 -380 replies
6/17selftests/bpf: Update expected test_offload.py messagestools/testing/selftests/bpf/test_offload.py+5 -50 replies
7/17bpf: XDP metadata RX kfuncsinclude/linux/bpf.h include/linux/netdevice.h include/net/xdp.h +5 more+188 -20 replies
8/17bpf: Support consuming XDP HW metadata from fext programsinclude/linux/bpf.h kernel/bpf/offload.c kernel/bpf/syscall.c +1 more+106 -320 replies
9/17veth: Introduce veth_xdp_buff wrapper for xdp_buffdrivers/net/veth.c+31 -250 replies
10/17veth: Support RX XDP metadatadrivers/net/veth.c+31 -00 replies
11/17selftests/bpf: Verify xdp_metadata xdp->af_xdp pathtools/testing/selftests/bpf/Makefile tools/testing/selftests/bpf/prog_tests/xdp_metadata.c tools/testing/selftests/bpf/progs/xdp_metadata.c +2 more+513 -14 replies
12/17net/mlx4_en: Introduce wrapper for xdp_buffdrivers/net/ethernet/mellanox/mlx4/en_rx.c+15 -110 replies
13/17net/mlx4_en: Support RX XDP metadatadrivers/net/ethernet/mellanox/mlx4/en_clock.c drivers/net/ethernet/mellanox/mlx4/en_netdev.c drivers/net/ethernet/mellanox/mlx4/en_rx.c +1 more+52 -50 replies
14/17xsk: Add cb area to struct xdp_buff_xskinclude/net/xsk_buff_pool.h+5 -00 replies
15/17net/mlx5e: Introduce wrapper for xdp_buffdrivers/net/ethernet/mellanox/mlx5/core/en/xdp.c drivers/net/ethernet/mellanox/mlx5/core/en/xdp.h drivers/net/ethernet/mellanox/mlx5/core/en/xsk/rx.c +1 more+57 -431 replyApplied
16/17net/mlx5e: Support RX XDP metadatadrivers/net/ethernet/mellanox/mlx5/core/en.h drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c +5 more+84 -262 repliesApplied
17/17selftests/bpf: Simple program to dump XDP RX metadatatools/testing/selftests/bpf/.gitignore tools/testing/selftests/bpf/Makefile tools/testing/selftests/bpf/progs/xdp_hw_metadata.c +1 more+491 -17 replies

Reviews trailers per patch

6 of 17 patches have a Reviewed-by or Acked-by.

PatchDavid VernetJakub KicinskiTariq Toukan
1/17A-b
2/17R-b
3/17
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17R-b
13/17R-b
14/17
15/17R-b
16/17R-b
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH bpf-next v8 00/17] xdp: hints via kfuncs

Please see the first patch in the series for the overall design and use-cases.

See the following email from Toke for the per-packet metadata overhead:
https://lore.kernel.org/bpf/[email protected]/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798

Recent changes:
- Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq)

- Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq)

- Clarify xdp_buff vs 'XDP frame' (Jesper)

- Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper)

- Drop libbpf_flags/xdp_flags from selftests and use ifindex instead of ifname (due to recent xsk.h refactoring)

Prior art (to record pros/cons for different approaches):

- Stable UAPI approach:
https://lore.kernel.org/bpf/[email protected]/
- Metadata+BTF_ID appoach:
https://lore.kernel.org/bpf/166256538687.1434226.15760041133601409770.stgit@firesoul/
- v7:
https://lore.kernel.org/bpf/[email protected]/
- v6:
https://lore.kernel.org/bpf/[email protected]/
- v5:
https://lore.kernel.org/bpf/[email protected]/
- v4:
https://lore.kernel.org/bpf/[email protected]/
- v3:
https://lore.kernel.org/bpf/[email protected]/
- v2:
https://lore.kernel.org/bpf/[email protected]/
- v1:
https://lore.kernel.org/bpf/[email protected]/
- kfuncs v2 RFC:
https://lore.kernel.org/bpf/[email protected]/
- kfuncs v1 RFC:
https://lore.kernel.org/bpf/[email protected]/

Cc John Fastabend <[email protected]>
Cc David Ahern <[email protected]>
Cc Martin KaFai Lau <[email protected]>
Cc Jakub Kicinski <[email protected]>
Cc Willem de Bruijn <[email protected]>
Cc Jesper Dangaard Brouer <[email protected]>
Cc Anatoly Burakov <[email protected]>
Cc Alexander Lobakin <[email protected]>
Cc Magnus Karlsson <[email protected]>
Cc Maryam Tahhan <[email protected]>

Stanislav Fomichev (13):
bpf: Document XDP RX metadata
bpf: Rename bpf_{prog,map}_is_dev_bound to is_offloaded
bpf: Move offload initialization into late_initcall
bpf: Reshuffle some parts of bpf/offload.c
bpf: Introduce device-bound XDP programs selftests/bpf: Update expected test_offload.py messages
bpf: XDP metadata RX kfuncs
veth: Introduce veth_xdp_buff wrapper for xdp_buff
veth: Support RX XDP metadata
selftests/bpf: Verify xdp_metadata xdp->af_xdp path net/mlx4_en: Introduce wrapper for xdp_buff net/mlx4_en: Support RX XDP metadata selftests/bpf: Simple program to dump XDP RX metadata

Toke Høiland-Jørgensen (4):
bpf: Support consuming XDP HW metadata from fext programs
xsk: Add cb area to struct xdp_buff_xsk net/mlx5e: Introduce wrapper for xdp_buff net/mlx5e: Support RX XDP metadata

 Documentation/networking/index.rst            |   1 +
 Documentation/networking/xdp-rx-metadata.rst  | 110 +++++
 drivers/net/ethernet/mellanox/mlx4/en_clock.c |  13 +-
 .../net/ethernet/mellanox/mlx4/en_netdev.c    |   6 +
 drivers/net/ethernet/mellanox/mlx4/en_rx.c    |  63 ++-
 drivers/net/ethernet/mellanox/mlx4/mlx4_en.h  |   5 +
 drivers/net/ethernet/mellanox/mlx5/core/en.h  |   5 +-
 .../net/ethernet/mellanox/mlx5/core/en/txrx.h |   5 +
 .../net/ethernet/mellanox/mlx5/core/en/xdp.c  |  31 +-
 .../net/ethernet/mellanox/mlx5/core/en/xdp.h  |  10 +-
 .../ethernet/mellanox/mlx5/core/en/xsk/rx.c   |  47 +-
 .../ethernet/mellanox/mlx5/core/en/xsk/rx.h   |   2 +
 .../net/ethernet/mellanox/mlx5/core/en_main.c |   1 +
 .../net/ethernet/mellanox/mlx5/core/en_rx.c   |  99 ++--
 drivers/net/netdevsim/bpf.c                   |   4 -
 drivers/net/veth.c                            |  87 ++--
 include/linux/bpf.h                           |  61 ++-
 include/linux/netdevice.h                     |   8 +
 include/net/xdp.h                             |  21 +
 include/net/xsk_buff_pool.h                   |   5 +
 include/uapi/linux/bpf.h                      |   5 +
 kernel/bpf/core.c                             |  12 +-
 kernel/bpf/offload.c                          | 425 ++++++++++++------
 kernel/bpf/syscall.c                          |  34 +-
 kernel/bpf/verifier.c                         |  44 +-
 net/bpf/test_run.c                            |   3 +
 net/core/dev.c                                |   9 +-
 net/core/filter.c                             |   2 +-
 net/core/xdp.c                                |  64 +++
 tools/include/uapi/linux/bpf.h                |   5 +
 tools/testing/selftests/bpf/.gitignore        |   1 +
 tools/testing/selftests/bpf/Makefile          |   9 +-
 .../selftests/bpf/prog_tests/xdp_metadata.c   | 410 +++++++++++++++++
 .../selftests/bpf/progs/xdp_hw_metadata.c     |  81 ++++
 .../selftests/bpf/progs/xdp_metadata.c        |  64 +++
 .../selftests/bpf/progs/xdp_metadata2.c       |  23 +
 tools/testing/selftests/bpf/test_offload.py   |  10 +-
 tools/testing/selftests/bpf/xdp_hw_metadata.c | 403 +++++++++++++++++
 tools/testing/selftests/bpf/xdp_metadata.h    |  15 +
 39 files changed, 1910 insertions(+), 293 deletions(-)
 create mode 100644 Documentation/networking/xdp-rx-metadata.rst
 create mode 100644 tools/testing/selftests/bpf/prog_tests/xdp_metadata.c
 create mode 100644 tools/testing/selftests/bpf/progs/xdp_hw_metadata.c
 create mode 100644 tools/testing/selftests/bpf/progs/xdp_metadata.c
 create mode 100644 tools/testing/selftests/bpf/progs/xdp_metadata2.c
 create mode 100644 tools/testing/selftests/bpf/xdp_hw_metadata.c
 create mode 100644 tools/testing/selftests/bpf/xdp_metadata.h
Signature · 1 line
2.39.0.246.g2a6d74b583-goog