xdp: hints via kfuncs
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest17 patches 22 repliesIn review 2 of 17 applied
- v717 patches 25 repliesSuperseded
- v617 patches 12 repliesSuperseded
Earlier versions · 7
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 17 patches | 20 replies | Superseded | |
| v4 | 15 patches | 29 replies | Superseded | |
| v3 posting 2/2 | 12 patches | 48 replies | Superseded | |
| v3 posting 1/2 | 11 patches | 7 replies | Superseded | |
| v2 posting 2/2 | 8 patches | 37 replies | Superseded | |
| v2 RFC posting 1/2 | 14 patches | 51 replies | Superseded | |
| v1 RFC | 5 patches | 44 replies | Superseded |
Patches in v8 2 of 17 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | bpf: Document XDP RX metadataDocumentation/ Documentation/ | +111 | 0 replies | |
| 2/17 | bpf: Rename bpf_{prog,map}_is_dev_bound to is_offloadedinclude/ kernel/ kernel/ +4 more | +31 | 0 replies | |
| 3/17 | bpf: Move offload initialization into late_initcallkernel/ | +7 | 0 replies | |
| 4/17 | bpf: Reshuffle some parts of bpf/offload.ckernel/ | +117 | 0 replies | |
| 5/17 | bpf: Introduce device-bound XDP programsdrivers/ include/ include/ +5 more | +113 | 0 replies | |
| 6/17 | selftests/bpf: Update expected test_offload.py messagestools/ | +5 | 0 replies | |
| 7/17 | bpf: XDP metadata RX kfuncsinclude/ include/ include/ +5 more | +188 | 0 replies | |
| 8/17 | bpf: Support consuming XDP HW metadata from fext programsinclude/ kernel/ kernel/ +1 more | +106 | 0 replies | |
| 9/17 | veth: Introduce veth_xdp_buff wrapper for xdp_buffdrivers/ | +31 | 0 replies | |
| 10/17 | veth: Support RX XDP metadatadrivers/ | +31 | 0 replies | |
| 11/17 | selftests/bpf: Verify xdp_metadata xdp->af_xdp pathtools/ tools/ tools/ +2 more | +513 | 4 replies | |
| 12/17 | net/mlx4_en: Introduce wrapper for xdp_buffdrivers/ | +15 | 0 replies | |
| 13/17 | net/mlx4_en: Support RX XDP metadatadrivers/ drivers/ drivers/ +1 more | +52 | 0 replies | |
| 14/17 | xsk: Add cb area to struct xdp_buff_xskinclude/ | +5 | 0 replies | |
| 15/17 | net/mlx5e: Introduce wrapper for xdp_buffdrivers/ drivers/ drivers/ +1 more | +57 | 1 reply | Applied |
| 16/17 | net/mlx5e: Support RX XDP metadatadrivers/ drivers/ drivers/ +5 more | +84 | 2 replies | Applied |
| 17/17 | selftests/bpf: Simple program to dump XDP RX metadatatools/ tools/ tools/ +1 more | +491 | 7 replies |
Reviews trailers per patch
6 of 17 patches have a Reviewed-by or Acked-by.
| Patch | David Vernet | Jakub Kicinski | Tariq Toukan |
|---|---|---|---|
| 1/17 | A-b | ||
| 2/17 | R-b | ||
| 3/17 | |||
| 4/17 | |||
| 5/17 | |||
| 6/17 | |||
| 7/17 | |||
| 8/17 | |||
| 9/17 | |||
| 10/17 | |||
| 11/17 | |||
| 12/17 | R-b | ||
| 13/17 | R-b | ||
| 14/17 | |||
| 15/17 | R-b | ||
| 16/17 | R-b | ||
| 17/17 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH bpf-next v8 00/17] xdp: hints via kfuncs
Please see the first patch in the series for the overall design and use-cases.
See the following email from Toke for the per-packet metadata overhead:
https://lore.kernel.org/bpf/[email protected]/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798
Recent changes:
- Keep new functions in en/xdp.c, do 'extern mlx5_xdp_metadata_ops' (Tariq)
- Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq)
- Clarify xdp_buff vs 'XDP frame' (Jesper)
- Explicitly mention that AF_XDP RX descriptor lacks metadata size (Jesper)
- Drop libbpf_flags/xdp_flags from selftests and use ifindex instead of ifname (due to recent xsk.h refactoring)
Prior art (to record pros/cons for different approaches):
- Stable UAPI approach:
https://lore.kernel.org/bpf/[email protected]/
- Metadata+BTF_ID appoach:
https://lore.kernel.org/bpf/166256538687.1434226.15760041133601409770.stgit@firesoul/
- v7:
https://lore.kernel.org/bpf/[email protected]/
- v6:
https://lore.kernel.org/bpf/[email protected]/
- v5:
https://lore.kernel.org/bpf/[email protected]/
- v4:
https://lore.kernel.org/bpf/[email protected]/
- v3:
https://lore.kernel.org/bpf/[email protected]/
- v2:
https://lore.kernel.org/bpf/[email protected]/
- v1:
https://lore.kernel.org/bpf/[email protected]/
- kfuncs v2 RFC:
https://lore.kernel.org/bpf/[email protected]/
- kfuncs v1 RFC:
https://lore.kernel.org/bpf/[email protected]/
Stanislav Fomichev (13):
bpf: Document XDP RX metadata
bpf: Rename bpf_{prog,map}_is_dev_bound to is_offloaded
bpf: Move offload initialization into late_initcall
bpf: Reshuffle some parts of bpf/offload.c
bpf: Introduce device-bound XDP programs selftests/bpf: Update expected test_offload.py messages
bpf: XDP metadata RX kfuncs
veth: Introduce veth_xdp_buff wrapper for xdp_buff
veth: Support RX XDP metadata
selftests/bpf: Verify xdp_metadata xdp->af_xdp path net/mlx4_en: Introduce wrapper for xdp_buff net/mlx4_en: Support RX XDP metadata selftests/bpf: Simple program to dump XDP RX metadata
Toke Høiland-Jørgensen (4):
bpf: Support consuming XDP HW metadata from fext programs
xsk: Add cb area to struct xdp_buff_xsk net/mlx5e: Introduce wrapper for xdp_buff net/mlx5e: Support RX XDP metadata
Documentation/networking/index.rst | 1 + Documentation/networking/xdp-rx-metadata.rst | 110 +++++ drivers/net/ethernet/mellanox/mlx4/en_clock.c | 13 +- .../net/ethernet/mellanox/mlx4/en_netdev.c | 6 + drivers/net/ethernet/mellanox/mlx4/en_rx.c | 63 ++- drivers/net/ethernet/mellanox/mlx4/mlx4_en.h | 5 + drivers/net/ethernet/mellanox/mlx5/core/en.h | 5 +- .../net/ethernet/mellanox/mlx5/core/en/txrx.h | 5 + .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 31 +- .../net/ethernet/mellanox/mlx5/core/en/xdp.h | 10 +- .../ethernet/mellanox/mlx5/core/en/xsk/rx.c | 47 +- .../ethernet/mellanox/mlx5/core/en/xsk/rx.h | 2 + .../net/ethernet/mellanox/mlx5/core/en_main.c | 1 + .../net/ethernet/mellanox/mlx5/core/en_rx.c | 99 ++-- drivers/net/netdevsim/bpf.c | 4 - drivers/net/veth.c | 87 ++-- include/linux/bpf.h | 61 ++- include/linux/netdevice.h | 8 + include/net/xdp.h | 21 + include/net/xsk_buff_pool.h | 5 + include/uapi/linux/bpf.h | 5 + kernel/bpf/core.c | 12 +- kernel/bpf/offload.c | 425 ++++++++++++------ kernel/bpf/syscall.c | 34 +- kernel/bpf/verifier.c | 44 +- net/bpf/test_run.c | 3 + net/core/dev.c | 9 +- net/core/filter.c | 2 +- net/core/xdp.c | 64 +++ tools/include/uapi/linux/bpf.h | 5 + tools/testing/selftests/bpf/.gitignore | 1 + tools/testing/selftests/bpf/Makefile | 9 +- .../selftests/bpf/prog_tests/xdp_metadata.c | 410 +++++++++++++++++ .../selftests/bpf/progs/xdp_hw_metadata.c | 81 ++++ .../selftests/bpf/progs/xdp_metadata.c | 64 +++ .../selftests/bpf/progs/xdp_metadata2.c | 23 + tools/testing/selftests/bpf/test_offload.py | 10 +- tools/testing/selftests/bpf/xdp_hw_metadata.c | 403 +++++++++++++++++ tools/testing/selftests/bpf/xdp_metadata.h | 15 + 39 files changed, 1910 insertions(+), 293 deletions(-) create mode 100644 Documentation/networking/xdp-rx-metadata.rst create mode 100644 tools/testing/selftests/bpf/prog_tests/xdp_metadata.c create mode 100644 tools/testing/selftests/bpf/progs/xdp_hw_metadata.c create mode 100644 tools/testing/selftests/bpf/progs/xdp_metadata.c create mode 100644 tools/testing/selftests/bpf/progs/xdp_metadata2.c create mode 100644 tools/testing/selftests/bpf/xdp_hw_metadata.c create mode 100644 tools/testing/selftests/bpf/xdp_metadata.h
Signature · 1 line
2.39.0.246.g2a6d74b583-goog