Skip to content

mlxbf_gige: add BlueField-3 support

David Thompson netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 2 repliesApplied 4/4
  2. v24 patches 14 repliesSuperseded
  3. v14 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- "mlxbf_gige: add BlueField-3 Serdes configuration" patch has been removed from the patch series, as this configuration is no longer needed within the Linux driver.
- "mlxbf_gige: add set_link_ksettings ethtool callback" patch has been split into two patches, moving the white space change to its own patch

Patches in v3 All 4 applied

#Subject and filesSizeRepliesApplied
1/4mlxbf_gige: add MDIO support for BlueField-3drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige.h drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio.c +3 more+251 -500 repliesApplied
2/4mlxbf_gige: support 10M/100M/1G speeds on BlueField-3drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige.h drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_regs.h+119 -151 replyApplied
3/4mlxbf_gige: add "set_link_ksettings" ethtool callbackdrivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_ethtool.c+1 -01 replyApplied
4/4mlxbf_gige: fix white space in mlxbf_gige_eth_ioctldrivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c+1 -10 repliesApplied

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/4
2/4R-b
3/4R-b
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/4] mlxbf_gige: add BlueField-3 support

This patch series adds driver logic to the "mlxbf_gige" Ethernet driver in order to support the third generation BlueField SoC (BF3). The existing "mlxbf_gige" driver is extended with BF3-specific logic and run-time decisions are made by the driver depending on the SoC generation (BF2 vs. BF3).

The BF3 SoC is similar to BF2 SoC with regards to transmit and receive packet processing:
* Driver rings usage; consumer & producer indices
* Single queue for receive and transmit
* DMA operation

The differences between BF3 and BF2 SoC are:
* In addition to supporting 1Gbps interface speed, the BF3 SoC adds support for 10Mbps and 100Mbps interface speeds
* BF3 requires SerDes config logic to support its SGMII interface
* BF3 adds support for "ethtool -s" for interface speed config
* BF3 utilizes different MDIO logic for accessing the board-level PHY device

Testing
- Successful build of kernel for ARM64, ARM32, X86_64
- Tested ARM64 build on FastModels, Palladium, SoC

v2 -> v3:
- "mlxbf_gige: add BlueField-3 Serdes configuration" patch has been removed from the patch series, as this configuration is no longer needed within the Linux driver.
- "mlxbf_gige: add set_link_ksettings ethtool callback" patch has been split into two patches, moving the white space change to its own patch

v1 -> v2:
- Fixed build failures in "build_32bit" and "build_allmodconfig_warn"
- Removed use of spinlock in BF3 "adjust_link" callback
- Added use of ARRAY_SIZE() where appropriate
- Added "set_link_ksettings" ethtool callback for BF2 and BF3

David Thompson (4):
mlxbf_gige: add MDIO support for BlueField-3
mlxbf_gige: support 10M/100M/1G speeds on BlueField-3
mlxbf_gige: add "set_link_ksettings" ethtool callback
mlxbf_gige: fix white space in mlxbf_gige_eth_ioctl

 .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h |  27 +++
 .../mellanox/mlxbf_gige/mlxbf_gige_ethtool.c  |   1 +
 .../mellanox/mlxbf_gige/mlxbf_gige_main.c     | 109 +++++++++--
 .../mellanox/mlxbf_gige/mlxbf_gige_mdio.c     | 172 +++++++++++++-----
 .../mellanox/mlxbf_gige/mlxbf_gige_mdio_bf2.h |  53 ++++++
 .../mellanox/mlxbf_gige/mlxbf_gige_mdio_bf3.h |  54 ++++++
 .../mellanox/mlxbf_gige/mlxbf_gige_regs.h     |  22 +++
 7 files changed, 372 insertions(+), 66 deletions(-)
 create mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio_bf2.h
 create mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_mdio_bf3.h
Signature · 1 line
2.30.1