tests/qtest: Enable running qtest on Windows
Get series with b4
b4 am [email protected]Versions newest first
- v6 Latest11 patches 20 repliesIn review
Changes in v6 from the cover letter
- drop patches that are already in Alex and Daniel's tree
- remove CONFIG_POSIX from meson.build
- include <qemu/sockets.h> in libqtest.c
- move documentation comments of qemu_send_full() from util/osdep.c
to qemu/sockets.h
- save the "exit_code" in struct QTestState
- new patch: "tests/qtest: device-plug-test: Reverse the usage of double/single quotes"
- new patch: "tests/qtest: Use EXIT_FAILURE instead of magic number"
- new patch: "tests/qtest: libqtest: Introduce qtest_wait_qemu()"
- change to use qtest_wait_qemu() API
- new patch: "test/qtest/libqos: meson.build: Do not build virtio-9p unconditionally"
Patches in v6 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | accel/qtest: Support qtest accelerator for Windowsaccel/ accel/ accel/ +2 more | +20 | 0 replies | |
| 2/11 | tests/qtest: Use send/recv for socket communicationinclude/ tests/ tests/ +1 more | +41 | 0 replies | |
| 3/11 | tests/qtest: Support libqtest to build and run on Windowstests/ | +94 | 0 replies | |
| 4/11 | tests/qtest: device-plug-test: Reverse the usage of double/single quotestests/ | +8 | 1 reply | |
| 5/11 | tests/qtest: Use EXIT_FAILURE instead of magic numbertests/ tests/ | +3 | 2 replies | |
| 6/11 | tests/qtest: libqtest: Introduce qtest_wait_qemu()tests/ tests/ | +47 | 1 reply | |
| 7/11 | tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceledtests/ | +4 | 1 reply | |
| 8/11 | tests/qtest: libqos: Do not build virtio-9p unconditionallytests/ | +4 | 4 replies | |
| 9/11 | tests/qtest: libqtest: Correct the timeout unit of blocking receive calls for win32tests/ | +10 | 0 replies | |
| 10/11 | .gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes.gitlab-ci.d/ | +2 | 0 replies | |
| 11/11 | tests/qtest: Enable qtest build on Windowstests/ | +0 | 6 replies |
Reviews trailers per patch
8 of 11 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Marc-André Lureau | Thomas Huth | Juan Quintela |
|---|---|---|---|
| Series | R-b | ||
| 1/11 | R-b | ||
| 2/11 | R-b | ||
| 3/11 | |||
| 4/11 | R-b | ||
| 5/11 | R-b | R-b | |
| 6/11 | |||
| 7/11 | R-b | ||
| 8/11 | R-b | ||
| 9/11 | R-b | ||
| 10/11 | |||
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 00/11] tests/qtest: Enable running qtest on Windows
In preparation to adding virtio-9p support on Windows, this series enables running qtest on Windows, so that we can run the virtio-9p tests on Windows to make sure it does not break accidently.
Changes in v6:
- drop patches that are already in Alex and Daniel's tree
- remove CONFIG_POSIX from meson.build
- include <qemu/sockets.h> in libqtest.c
- move documentation comments of qemu_send_full() from util/osdep.c
to qemu/sockets.h
- save the "exit_code" in struct QTestState
- new patch: "tests/qtest: device-plug-test: Reverse the usage of double/single quotes"
- new patch: "tests/qtest: Use EXIT_FAILURE instead of magic number"
- new patch: "tests/qtest: libqtest: Introduce qtest_wait_qemu()"
- change to use qtest_wait_qemu() API
- new patch: "test/qtest/libqos: meson.build: Do not build virtio-9p unconditionally"
Changes in v5:
- restore to v1 version which does not touch the posix implementation
- Drop patches that are already merged
Changes in v3:
- Add a usleep(1) in the busy wait loop
- Drop the host test
Changes in v2:
- Introduce qemu_send_full() and use it
- Move the enabling of building qtests on Windows to a separate patch to keep bisectablity
- Call socket_init() unconditionally
- Add a missing CloseHandle() call
- Change to a busy wait after migration is canceled
- Change the timeout limit to 90 minutes
- new patch: "tests/qtest: Enable qtest build on Windows"
Bin Meng (8):
tests/qtest: Support libqtest to build and run on Windows tests/qtest: device-plug-test: Reverse the usage of double/single
quotes
tests/qtest: Use EXIT_FAILURE instead of magic number tests/qtest: libqtest: Introduce qtest_wait_qemu() tests/qtest: libqos: Do not build virtio-9p unconditionally tests/qtest: libqtest: Correct the timeout unit of blocking receive
calls for win32
.gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes tests/qtest: Enable qtest build on Windows
Xuzhou Cheng (3):
accel/qtest: Support qtest accelerator for Windows tests/qtest: Use send/recv for socket communication tests/qtest: migration-test: Make sure QEMU process "to" exited after
migration is canceled
include/hw/core/cpu.h | 1 + include/qemu/sockets.h | 13 +++ tests/qtest/libqtest.h | 9 ++ accel/dummy-cpus.c | 14 ++- softmmu/cpus.c | 9 +- tests/qtest/dbus-vmstate-test.c | 2 +- tests/qtest/device-plug-test.c | 16 ++-- tests/qtest/libqmp.c | 5 +- tests/qtest/libqtest.c | 151 ++++++++++++++++++++++++++++---- tests/qtest/migration-test.c | 8 +- util/osdep.c | 22 +++++ .gitlab-ci.d/windows.yml | 4 +- accel/meson.build | 2 +- accel/qtest/meson.build | 3 +- tests/qtest/libqos/meson.build | 6 +- tests/qtest/meson.build | 6 -- 16 files changed, 221 insertions(+), 50 deletions(-)
Signature · 1 line
2.25.1