Skip to content

Makefile: rework u-boot-initial-env target

Max Krummenacher u-boot 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest1 patch 4 repliesIn review
  2. v41 patch 5 repliesSuperseded
  3. v31 patch 1 replySuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v21 patch7 repliesSuperseded

Changes in v5 from the cover letter

- don't build the printinitialenv tool unconditionally but build it only as part of the u-boot-initial-env target.
This no longer fails the 'make tools-only_defconfig tools-only' use-case which is reported by Tom Rini.
Adding the $(env_h) dependencies to the tools target might give circular dependencies issues with some future tool.
- add Acked-by: Pali Rohár <[email protected]>

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1u-boot-initial-env: rework make targetMakefile tools/.gitignore tools/Makefile +1 more+55 -44 replies

Reviews trailers per patch

The patch has a Reviewed-by or Acked-by.

PatchPali RohárSimon Glass
1/1A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/1] Makefile: rework u-boot-initial-env target

From: Max Krummenacher <[email protected]>

With CONFIG_LTO enabled the current way of extracting the configured environment no longer works, i.e. the object file content changes due to LTO.

Build a host tool which prints the configured environment instead of using objcopy and friends to achive the same.

The code and Makefile changes were mostly stolen from tools/env/ i.e. the target userspace tools to access the environment.

Changes in v5:
- don't build the printinitialenv tool unconditionally but build it only as part of the u-boot-initial-env target.
This no longer fails the 'make tools-only_defconfig tools-only' use-case which is reported by Tom Rini.
Adding the $(env_h) dependencies to the tools target might give circular dependencies issues with some future tool.
- add Acked-by: Pali Rohár <[email protected]>

Changes in v4:
- add '(objtree)/' when calling the tool. Suggested by Pali Rohár.
- renamed patch, as more than just the Makefile has changes

Changes in v3:
- moved the tool from scripts/ to tools/. Suggested by Tom Rini
- changed the dependencies to '$(env_h)' and 'tools'. Suggested by Tom Rini and Pali Rohár.
- removed the sed rule which replaces \x00 with \x0A as this is already done by the tool. Suggested by Pali Rohár.

Changes in v2:
- reworked to build a host tool which prints the configured environment as proposed by Pali Rohár
https://lore.kernel.org/u-boot/[email protected]/
- renamed patch, v1 used "Makefile: fix u-boot-initial-env target if lto is enabled"

Max Krummenacher (1):
u-boot-initial-env: rework make target

 Makefile                | 10 ++++++----
 tools/.gitignore        |  1 +
 tools/Makefile          |  4 ++++
 tools/printinitialenv.c | 44 +++++++++++++++++++++++++++++++++++++++++
 4 files changed, 55 insertions(+), 4 deletions(-)
 create mode 100644 tools/printinitialenv.c
Signature · 1 line
2.35.3