RFC Remove STACK_FRAME_OVERHEAD
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest19 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/19 | powerpc/perf: callchain validate kernel stack pointer boundsarch/ | +1 | 1 reply | |
| 2/19 | powerpc: Rearrange copy_thread child stack creationarch/ | +6 | 0 replies | |
| 3/19 | powerpc/64: Remove asm interrupt tracing call helpersarch/ | +0 | 0 replies | |
| 4/19 | powerpc/pseries: hvcall stack frame overheadarch/ | +20 | 0 replies | |
| 5/19 | powerpc/32: Use load and store multiple in GPR save/restore macrosarch/ | +16 | 3 replies | |
| 6/19 | powerpc: simplify ppc_save_regsarch/ | +14 | 0 replies | |
| 7/19 | powerpc: add definition for pt_regs offset within an interrupt framearch/ arch/ arch/ +15 more | +100 | 0 replies | |
| 8/19 | powerpc: add a definition for the marker offset within the interrupt framearch/ arch/ arch/ +5 more | +13 | 0 replies | |
| 9/19 | powerpc: Rename STACK_FRAME_MARKER and derive it from frame offsetarch/ arch/ arch/ +2 more | +6 | 0 replies | |
| 10/19 | powerpc: add a define for the user interrupt frame sizearch/ arch/ arch/ | +8 | 0 replies | |
| 11/19 | powerpc: add a define for the switch frame size and regs offsetarch/ arch/ arch/ +1 more | +16 | 0 replies | |
| 12/19 | powerpc: copy_thread fill in interrupt frame marker and back chainarch/ | +3 | 0 replies | |
| 13/19 | powerpc: copy_thread add a back chain to the switch stack framearch/ | +2 | 0 replies | |
| 14/19 | powerpc: split validate_sp into two functionsarch/ arch/ arch/ +1 more | +30 | 2 replies | |
| 15/19 | powerpc: allow minimum sized kernel stack framesarch/ arch/ arch/ +9 more | +20 | 0 replies | |
| 16/19 | powerpc/64: ELFv2 use minimal stack frames in int and switch frame sizesarch/ | +15 | 0 replies | |
| 17/19 | powerpc: remove STACK_FRAME_OVERHEADarch/ | +11 | 0 replies | |
| 18/19 | powerpc: change stack marker memory operations to 32-bitarch/ arch/ arch/ +4 more | +10 | 0 replies | |
| 19/19 | powerpc/64: ELFv2 use reserved word in the stack frame for the regs markerarch/ | +10 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 00/19] Remove STACK_FRAME_OVERHEAD
This is some quick hacking, hardly tested but might have potential.
I think we're not validating the perf kernel stack walker bounds quite correctly, and not setting up decent stack frames for the child in copy_thread. So at least those two things we could do. Maybe patch 1 should go upstream as a fix.
Thanks,
Nick
Nicholas Piggin (19):
powerpc/perf: callchain validate kernel stack pointer bounds
powerpc: Rearrange copy_thread child stack creation powerpc/64: Remove asm interrupt tracing call helpers powerpc/pseries: hvcall stack frame overhead
powerpc/32: Use load and store multiple in GPR save/restore macros
powerpc: simplify ppc_save_regs
powerpc: add definition for pt_regs offset within an interrupt frame
powerpc: add a definition for the marker offset within the interrupt
frame
powerpc: Rename STACK_FRAME_MARKER and derive it from frame offset
powerpc: add a define for the user interrupt frame size
powerpc: add a define for the switch frame size and regs offset
powerpc: copy_thread fill in interrupt frame marker and back chain
powerpc: copy_thread add a back chain to the switch stack frame
powerpc: split validate_sp into two functions
powerpc: allow minimum sized kernel stack frames powerpc/64: ELFv2 use minimal stack frames in int and switch frame
sizes
powerpc: remove STACK_FRAME_OVERHEAD
powerpc: change stack marker memory operations to 32-bit powerpc/64: ELFv2 use reserved word in the stack frame for the regs
marker
arch/powerpc/include/asm/irqflags.h | 29 ------- arch/powerpc/include/asm/ppc_asm.h | 18 +++- arch/powerpc/include/asm/processor.h | 15 +++- arch/powerpc/include/asm/ptrace.h | 41 +++++++--- arch/powerpc/kernel/asm-offsets.c | 9 +- arch/powerpc/kernel/entry_32.S | 14 ++-- arch/powerpc/kernel/exceptions-64e.S | 44 +++++----- arch/powerpc/kernel/exceptions-64s.S | 82 +++++++++---------- arch/powerpc/kernel/head_32.h | 4 +- arch/powerpc/kernel/head_40x.S | 2 +- arch/powerpc/kernel/head_44x.S | 6 +- arch/powerpc/kernel/head_64.S | 6 +- arch/powerpc/kernel/head_85xx.S | 8 +- arch/powerpc/kernel/head_8xx.S | 2 +- arch/powerpc/kernel/head_book3s_32.S | 4 +- arch/powerpc/kernel/head_booke.h | 4 +- arch/powerpc/kernel/interrupt_64.S | 32 ++++---- arch/powerpc/kernel/irq.c | 4 +- arch/powerpc/kernel/kgdb.c | 2 +- arch/powerpc/kernel/misc_32.S | 2 +- arch/powerpc/kernel/misc_64.S | 4 +- arch/powerpc/kernel/optprobes_head.S | 4 +- arch/powerpc/kernel/ppc_save_regs.S | 58 ++++--------- arch/powerpc/kernel/process.c | 54 +++++++----- arch/powerpc/kernel/smp.c | 2 +- arch/powerpc/kernel/stacktrace.c | 10 +-- arch/powerpc/kernel/tm.S | 8 +- arch/powerpc/kernel/trace/ftrace_mprofile.S | 2 +- arch/powerpc/kvm/book3s_hv_rmhandlers.S | 2 +- .../lib/test_emulate_step_exec_instr.S | 2 +- arch/powerpc/perf/callchain.c | 9 +- arch/powerpc/platforms/pseries/hvCall.S | 38 +++++---- arch/powerpc/xmon/xmon.c | 10 +-- 33 files changed, 263 insertions(+), 268 deletions(-)
Signature · 1 line
2.37.2