Skip to content

RFC Remove STACK_FRAME_OVERHEAD

Nicholas Piggin linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest19 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19powerpc/perf: callchain validate kernel stack pointer boundsarch/powerpc/perf/callchain.c+1 -01 reply
2/19powerpc: Rearrange copy_thread child stack creationarch/powerpc/kernel/process.c+6 -50 replies
3/19powerpc/64: Remove asm interrupt tracing call helpersarch/powerpc/include/asm/irqflags.h+0 -290 replies
4/19powerpc/pseries: hvcall stack frame overheadarch/powerpc/platforms/pseries/hvCall.S+20 -180 replies
5/19powerpc/32: Use load and store multiple in GPR save/restore macrosarch/powerpc/include/asm/ppc_asm.h+16 -23 replies
6/19powerpc: simplify ppc_save_regsarch/powerpc/kernel/ppc_save_regs.S+14 -440 replies
7/19powerpc: add definition for pt_regs offset within an interrupt framearch/powerpc/include/asm/ptrace.h arch/powerpc/kernel/asm-offsets.c arch/powerpc/kernel/entry_32.S +15 more+100 -1000 replies
8/19powerpc: add a definition for the marker offset within the interrupt framearch/powerpc/include/asm/ptrace.h arch/powerpc/kernel/entry_32.S arch/powerpc/kernel/exceptions-64e.S +5 more+13 -110 replies
9/19powerpc: Rename STACK_FRAME_MARKER and derive it from frame offsetarch/powerpc/include/asm/ptrace.h arch/powerpc/kernel/process.c arch/powerpc/kernel/stacktrace.c +2 more+6 -70 replies
10/19powerpc: add a define for the user interrupt frame sizearch/powerpc/include/asm/ptrace.h arch/powerpc/kernel/process.c arch/powerpc/kernel/stacktrace.c+8 -80 replies
11/19powerpc: add a define for the switch frame size and regs offsetarch/powerpc/include/asm/ptrace.h arch/powerpc/kernel/asm-offsets.c arch/powerpc/kernel/entry_32.S +1 more+16 -100 replies
12/19powerpc: copy_thread fill in interrupt frame marker and back chainarch/powerpc/kernel/process.c+3 -10 replies
13/19powerpc: copy_thread add a back chain to the switch stack framearch/powerpc/kernel/process.c+2 -00 replies
14/19powerpc: split validate_sp into two functionsarch/powerpc/include/asm/processor.h arch/powerpc/kernel/process.c arch/powerpc/kernel/stacktrace.c +1 more+30 -162 replies
15/19powerpc: allow minimum sized kernel stack framesarch/powerpc/kernel/head_40x.S arch/powerpc/kernel/head_44x.S arch/powerpc/kernel/head_64.S +9 more+20 -200 replies
16/19powerpc/64: ELFv2 use minimal stack frames in int and switch frame sizesarch/powerpc/include/asm/ptrace.h+15 -60 replies
17/19powerpc: remove STACK_FRAME_OVERHEADarch/powerpc/include/asm/ptrace.h+11 -130 replies
18/19powerpc: change stack marker memory operations to 32-bitarch/powerpc/include/asm/ptrace.h arch/powerpc/kernel/exceptions-64e.S arch/powerpc/kernel/exceptions-64s.S +4 more+10 -110 replies
19/19powerpc/64: ELFv2 use reserved word in the stack frame for the regs markerarch/powerpc/include/asm/ptrace.h+10 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/19] Remove STACK_FRAME_OVERHEAD

This is some quick hacking, hardly tested but might have potential.

I think we're not validating the perf kernel stack walker bounds quite correctly, and not setting up decent stack frames for the child in copy_thread. So at least those two things we could do. Maybe patch 1 should go upstream as a fix.

Thanks,
Nick

Nicholas Piggin (19):
powerpc/perf: callchain validate kernel stack pointer bounds
powerpc: Rearrange copy_thread child stack creation powerpc/64: Remove asm interrupt tracing call helpers powerpc/pseries: hvcall stack frame overhead
powerpc/32: Use load and store multiple in GPR save/restore macros
powerpc: simplify ppc_save_regs
powerpc: add definition for pt_regs offset within an interrupt frame
powerpc: add a definition for the marker offset within the interrupt
frame
powerpc: Rename STACK_FRAME_MARKER and derive it from frame offset
powerpc: add a define for the user interrupt frame size
powerpc: add a define for the switch frame size and regs offset
powerpc: copy_thread fill in interrupt frame marker and back chain
powerpc: copy_thread add a back chain to the switch stack frame
powerpc: split validate_sp into two functions
powerpc: allow minimum sized kernel stack frames powerpc/64: ELFv2 use minimal stack frames in int and switch frame
sizes
powerpc: remove STACK_FRAME_OVERHEAD
powerpc: change stack marker memory operations to 32-bit powerpc/64: ELFv2 use reserved word in the stack frame for the regs
marker

 arch/powerpc/include/asm/irqflags.h           | 29 -------
 arch/powerpc/include/asm/ppc_asm.h            | 18 +++-
 arch/powerpc/include/asm/processor.h          | 15 +++-
 arch/powerpc/include/asm/ptrace.h             | 41 +++++++---
 arch/powerpc/kernel/asm-offsets.c             |  9 +-
 arch/powerpc/kernel/entry_32.S                | 14 ++--
 arch/powerpc/kernel/exceptions-64e.S          | 44 +++++-----
 arch/powerpc/kernel/exceptions-64s.S          | 82 +++++++++----------
 arch/powerpc/kernel/head_32.h                 |  4 +-
 arch/powerpc/kernel/head_40x.S                |  2 +-
 arch/powerpc/kernel/head_44x.S                |  6 +-
 arch/powerpc/kernel/head_64.S                 |  6 +-
 arch/powerpc/kernel/head_85xx.S               |  8 +-
 arch/powerpc/kernel/head_8xx.S                |  2 +-
 arch/powerpc/kernel/head_book3s_32.S          |  4 +-
 arch/powerpc/kernel/head_booke.h              |  4 +-
 arch/powerpc/kernel/interrupt_64.S            | 32 ++++----
 arch/powerpc/kernel/irq.c                     |  4 +-
 arch/powerpc/kernel/kgdb.c                    |  2 +-
 arch/powerpc/kernel/misc_32.S                 |  2 +-
 arch/powerpc/kernel/misc_64.S                 |  4 +-
 arch/powerpc/kernel/optprobes_head.S          |  4 +-
 arch/powerpc/kernel/ppc_save_regs.S           | 58 ++++---------
 arch/powerpc/kernel/process.c                 | 54 +++++++-----
 arch/powerpc/kernel/smp.c                     |  2 +-
 arch/powerpc/kernel/stacktrace.c              | 10 +--
 arch/powerpc/kernel/tm.S                      |  8 +-
 arch/powerpc/kernel/trace/ftrace_mprofile.S   |  2 +-
 arch/powerpc/kvm/book3s_hv_rmhandlers.S       |  2 +-
 .../lib/test_emulate_step_exec_instr.S        |  2 +-
 arch/powerpc/perf/callchain.c                 |  9 +-
 arch/powerpc/platforms/pseries/hvCall.S       | 38 +++++----
 arch/powerpc/xmon/xmon.c                      | 10 +--
 33 files changed, 263 insertions(+), 268 deletions(-)
Signature · 1 line
2.37.2