Skip to content

tools/xenstore: do some cleanup and fixes

Juergen Gross xen-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest17 patches 6 repliesIn review
  2. v317 patches 21 repliesSuperseded
  3. v219 patches 24 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v120 patches46 repliesSuperseded

Changes in v4 from the cover letter

- reordered the patches a little bit (patch 4 and patch 17 of V4 have been moved)
- addressed comments

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17tools/xenstore: let talloc_free() preserve errnotools/xenstore/talloc.c tools/xenstore/xenstored_core.c+13 -100 replies
2/17tools/xenstore: remove all watches when a domain has stoppedtools/xenstore/xenstored_domain.c+3 -00 replies
3/17tools/xenstore: add hashlist for finding struct domain by domidtools/xenstore/xenstored_domain.c+60 -420 replies
4/17tools/xenstore: make log macro globally availabletools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h+15 -140 replies
5/17tools/xenstore: introduce dummy nodes for special watch pathstools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c tools/xenstore/xenstored_domain.c +2 more+83 -2010 replies
6/17tools/xenstore: replace watch->relative_path with a prefix lengthtools/xenstore/xenstored_watch.c+4 -150 replies
7/17tools/xenstore: move changed domain handlingtools/xenstore/xenstored_domain.c tools/xenstore/xenstored_domain.h tools/xenstore/xenstored_transaction.c+85 -600 replies
8/17tools/xenstore: change per-domain node accounting interfacetools/xenstore/xenstored_core.c tools/xenstore/xenstored_core.h tools/xenstore/xenstored_domain.c +3 more+87 -1051 reply
9/17tools/xenstore: replace literal domid 0 with dom0_domidtools/xenstore/xenstored_core.c tools/xenstore/xenstored_domain.c+7 -60 replies
10/17tools/xenstore: make domain_is_unprivileged() an inline functiontools/xenstore/xenstored_core.h tools/xenstore/xenstored_domain.c tools/xenstore/xenstored_domain.h+10 -130 replies
11/17tools/xenstore: let chk_domain_generation() return a booltools/xenstore/xenstored_domain.c+8 -100 replies
12/17tools/xenstore: don't let hashtable_remove() return the removed valuetools/xenstore/hashtable.c tools/xenstore/hashtable.h+5 -71 reply
13/17tools/xenstore: switch hashtable to use the talloc frameworktools/xenstore/hashtable.c tools/xenstore/hashtable.h tools/xenstore/xenstored_core.c +1 more+38 -700 replies
14/17tools/xenstore: introduce trace classesdocs/misc/xenstore.txt tools/xenstore/xenstored_control.c tools/xenstore/xenstored_core.c +3 more+108 -241 reply
15/17tools/xenstore: let check_store() check the accounting datatools/xenstore/xenstored_core.c tools/xenstore/xenstored_domain.c tools/xenstore/xenstored_domain.h+137 -151 reply
16/17tools/xenstore: make output of "xenstore-control help" more prettytools/xenstore/xenstored_control.c+1 -10 replies
17/17tools/xenstore: don't allow creating too many nodes in a transactiontools/xenstore/xenstored_domain.c+2 -30 replies

Reviews trailers per patch

16 of 17 patches have a Reviewed-by or Acked-by.

PatchJulien Grall
1/17R-b
2/17R-b
3/17R-b
4/17R-b
5/17R-b
6/17R-b
7/17R-b
8/17R-b
9/17R-b
10/17A-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b
15/17R-b
16/17R-b
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/17] tools/xenstore: do some cleanup and fixes

This is a first run of post-XSA patches which piled up during the development phase of all the recent Xenstore related XSA patches.

This is a mixture of small fixes, enhancements and cleanups.

Changes in V4:
- reordered the patches a little bit (patch 4 and patch 17 of V4 have been moved)
- addressed comments

Changes in V3:
- patches 2, 3, and 5 of V2 have been applied already
- new patch 12
- addressed comments

Changes in V2:
- patches 1+2 of V1 have been applied already
- addressed comments
- new patch 19

Juergen Gross (17):
tools/xenstore: let talloc_free() preserve errno tools/xenstore: remove all watches when a domain has stopped tools/xenstore: add hashlist for finding struct domain by domid tools/xenstore: make log macro globally available tools/xenstore: introduce dummy nodes for special watch paths tools/xenstore: replace watch->relative_path with a prefix length tools/xenstore: move changed domain handling tools/xenstore: change per-domain node accounting interface tools/xenstore: replace literal domid 0 with dom0_domid tools/xenstore: make domain_is_unprivileged() an inline function tools/xenstore: let chk_domain_generation() return a bool tools/xenstore: don't let hashtable_remove() return the removed value tools/xenstore: switch hashtable to use the talloc framework tools/xenstore: introduce trace classes
tools/xenstore: let check_store() check the accounting data tools/xenstore: make output of "xenstore-control help" more pretty tools/xenstore: don't allow creating too many nodes in a transaction

 docs/misc/xenstore.txt                 |  10 +-
 tools/xenstore/hashtable.c             | 103 ++--
 tools/xenstore/hashtable.h             |   6 +-
 tools/xenstore/talloc.c                |  21 +-
 tools/xenstore/xenstored_control.c     |  36 +-
 tools/xenstore/xenstored_core.c        | 261 +++++++----
 tools/xenstore/xenstored_core.h        |  39 ++
 tools/xenstore/xenstored_domain.c      | 620 +++++++++++++------------
 tools/xenstore/xenstored_domain.h      |  21 +-
 tools/xenstore/xenstored_transaction.c |  76 +--
 tools/xenstore/xenstored_transaction.h |   7 +-
 tools/xenstore/xenstored_watch.c       |  36 +-
 12 files changed, 653 insertions(+), 583 deletions(-)
Signature · 1 line
2.35.3