Skip to content

pinctrl: intel: Enable PWM optional feature

Andy Shevchenko linux-gpio linux-pwm lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 8 repliesIn review
  2. v47 patches 7 repliesSuperseded
  3. v36 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches24 repliesSuperseded
v16 patches1 replySuperseded

Changes in v5 from the cover letter

- added more tags (Uwe)
- avoid moving struct pwm_lpss_chip in patch 3 (Uwe)
- simplified error checking in intel_pinctrl_probe_pwm() (Uwe)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7pwm: Add a stub for devm_pwmchip_add()include/linux/pwm.h+5 -00 replies
2/7pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMSdrivers/pwm/pwm-lpss.c drivers/pwm/pwm-lpss.h+2 -20 replies
3/7pwm: lpss: Include headers we are the direct user ofdrivers/pwm/pwm-lpss.h+3 -12 replies
4/7pwm: lpss: Allow other drivers to enable PWM LPSSdrivers/pwm/pwm-lpss.h include/linux/platform_data/x86/pwm-lpss.h+6 -440 replies
5/7pwm: lpss: Rename pwm_lpss_probe() --> devm_pwm_lpss_probe()drivers/pwm/pwm-lpss-pci.c drivers/pwm/pwm-lpss-platform.c drivers/pwm/pwm-lpss.c +1 more+7 -70 replies
6/7pwm: lpss: Add devm_pwm_lpss_probe() stubinclude/linux/platform_data/x86/pwm-lpss.h+11 -05 replies
7/7pinctrl: intel: Enumerate PWM device when community has a capabilitydrivers/pinctrl/intel/pinctrl-intel.c+29 -00 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchThierry RedingMika WesterbergUwe Kleine-KönigHans de GoedeLinus Walleij
1/7A-b R-b A-b
2/7A-b R-b R-b
3/7A-b R-b A-b R-b
4/7A-b R-b A-b R-b
5/7A-b
6/7A-b R-b
7/7A-b R-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/7] pinctrl: intel: Enable PWM optional feature

This is a continuation of the previously applied PWM LPSS cleanup series. Now, we would like to enable PWM optional feature that may be embedded into Intel pin control IPs (starting from Sky Lake platforms).

I would like to route this via Intel pin control tree with issuing an immutable branch for both PINCTRL and PWM subsystems, but I'm open for other suggestions.

Hans, I dared to leave your Rb tags, however the patches are slightly differ, because of the Uwe's suggestion on how to handle the missing headers. I hope you are okay with that. If not, please comment what must be amended then.

Uwe, the patches 3 and 6 still need your blessing.

Changelog v5:
- added more tags (Uwe)
- avoid moving struct pwm_lpss_chip in patch 3 (Uwe)
- simplified error checking in intel_pinctrl_probe_pwm() (Uwe)

Changelog v4:
- added patch "Rename pwm_lpss_probe() --> devm_pwm_lpss_probe()"

Changelog v3:
- added tags (Uwe, Linus, Thierry)
- fixed some spelling issues in the commit messages
- changed a paragraph in the commit message of the patch 3 (Uwe)
- replaced -ENODEV check with IS_REACHABLE() in the patch 6 (Uwe)

Changelog v2:
- added tag (Mika)
- added base-commit to the series, to make sure LKP can test it

Cc Hans de Goede <[email protected]>
Cc Mika Westerberg <[email protected]>

Andy Shevchenko (7):
pwm: Add a stub for devm_pwmchip_add()
pwm: lpss: Rename MAX_PWMS --> LPSS_MAX_PWMS
pwm: lpss: Include headers we are the direct user of
pwm: lpss: Allow other drivers to enable PWM LPSS
pwm: lpss: Rename pwm_lpss_probe() --> devm_pwm_lpss_probe()
pwm: lpss: Add devm_pwm_lpss_probe() stub
pinctrl: intel: Enumerate PWM device when community has a capability

 drivers/pinctrl/intel/pinctrl-intel.c      | 29 ++++++++++++++
 drivers/pwm/pwm-lpss-pci.c                 |  2 +-
 drivers/pwm/pwm-lpss-platform.c            |  2 +-
 drivers/pwm/pwm-lpss.c                     |  8 ++--
 drivers/pwm/pwm-lpss.h                     | 26 ++-----------
 include/linux/platform_data/x86/pwm-lpss.h | 44 ++++++++++++++++++++++
 include/linux/pwm.h                        |  5 +++
 7 files changed, 88 insertions(+), 28 deletions(-)
 create mode 100644 include/linux/platform_data/x86/pwm-lpss.h

base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780

Signature · 1 line
2.35.1