Skip to content

efficiently expose damos action tried regions information

SeongJae Park damon linux-doc linux-kselftest linux-mm lkml 1 version Applied

Status from this message: [merged mm-stable] docs-admin-guide-mm-damon-usage-document-schemes-s-tried_regions-sysfs-directory.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesApplied 8/8

Patches in v1 All 8 applied

#Subject and filesSizeRepliesApplied
1/8mm/damon/core: add a callback for scheme target regions checkinclude/linux/damon.h mm/damon/core.c+10 -10 repliesApplied
2/8mm/damon/sysfs-schemes: implement schemes/tried_regions directorymm/damon/sysfs-schemes.c+57 -00 repliesApplied
3/8mm/damon/sysfs-schemes: implement scheme region directorymm/damon/sysfs-schemes.c+122 -10 repliesApplied
4/8mm/damon/sysfs: implement DAMOS tried regions update commandmm/damon/sysfs-common.h mm/damon/sysfs-schemes.c mm/damon/sysfs.c+136 -20 repliesApplied
5/8mm/damon/sysfs-schemes: implement DAMOS-tried regions clear commandmm/damon/sysfs-common.h mm/damon/sysfs-schemes.c mm/damon/sysfs.c+33 -10 repliesApplied
6/8tools/selftets/damon/sysfs: test tried_regions directory existencetools/testing/selftests/damon/sysfs.sh+7 -00 repliesApplied
7/8Docs/admin-guide/mm/damon/usage: document schemes/<s>/tried_regions sysfs directoryDocumentation/admin-guide/mm/damon/usage.rst+42 -30 repliesApplied
8/8Docs/ABI/damon: document 'schemes/<s>/tried_regions' sysfs directoryDocumentation/ABI/testing/sysfs-kernel-mm-damon+32 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] efficiently expose damos action tried regions information

Changes from RFC
(https://lore.kernel.org/damon/[email protected]/):
- Split out cleanup/refactoring parts[1]

[1] https://lore.kernel.org/damon/[email protected]/

-----------------------------------------------------------------------

DAMON users can retrieve the monitoring results via 'after_aggregation' callbacks if the user is using the kernel API, or 'damon_aggregated' tracepoint if the user is in the user space. Those are useful if full monitoring results are necessary. However, if the user has interest in only a snapshot of the results for some regions having specific access pattern, the interfaces could be inefficient. For example, some users only want to know which memory regions are not accessed for more than a specific time at the moment.

Also, some DAMOS users would want to know exactly to what memory regions the schemes' actions tried to be applied, for a debugging or a tuning. As DAMOS has its internal mechanism for quota and regions prioritization, the users would need to simulate DAMOS' mechanism against the monitoring results. That's unnecessarily complex.

This patchset implements DAMON kernel API callbacks and sysfs directory for efficient exposure of the information for the use cases. The new callback will be called for each region when a DAMOS action is gonna tried to be applied to it. The sysfs directory will be called 'tried_regions' and placed under each scheme sysfs directory. Users can write a special keyworkd, 'update_schemes_regions', to the 'state' file of a kdamond sysfs directory. Then, DAMON sysfs interface will fill the directory with the information of regions that corresponding scheme action was tried to be applied for next one aggregation interval.

Patches Sequence
----------------

The first one (patch 1) implements the callback for the kernel space users. Following two patches (patches 2 and 3) implements sysfs directories for the information and its sub directories. Two patches (patches 4 and 5) for implementing the special keywords for filling the data to and cleaning up the directories follow. Patch 6 adds a selftest for the new sysfs directory. Finally, two patches (patches 7 and 8) document the new feature in the administrator guide and the ABI document.

Assembled Tree
--------------

This patchset is based on the latest mm-unstable tree[1]. Assembled tree is also available at the damon/next tree[2].

[1] https://git.kernel.org/akpm/mm/h/mm-unstable
[2] https://git.kernel.org/sj/h/damon/next

SeongJae Park (8):
mm/damon/core: add a callback for scheme target regions check mm/damon/sysfs-schemes: implement schemes/tried_regions directory mm/damon/sysfs-schemes: implement scheme region directory mm/damon/sysfs: implement DAMOS tried regions update command mm/damon/sysfs-schemes: implement DAMOS-tried regions clear command tools/selftets/damon/sysfs: test tried_regions directory existence Docs/admin-guide/mm/damon/usage: document schemes/<s>/tried_regions
sysfs directory
Docs/ABI/damon: document 'schemes/<s>/tried_regions' sysfs directory

 .../ABI/testing/sysfs-kernel-mm-damon         |  32 +++
 Documentation/admin-guide/mm/damon/usage.rst  |  45 ++-
 include/linux/damon.h                         |   5 +
 mm/damon/core.c                               |   6 +-
 mm/damon/sysfs-common.h                       |  10 +
 mm/damon/sysfs-schemes.c                      | 261 ++++++++++++++++++
 mm/damon/sysfs.c                              |  77 +++++-
 tools/testing/selftests/damon/sysfs.sh        |   7 +
 8 files changed, 437 insertions(+), 6 deletions(-)
Signature · 1 line
2.25.1