Skip to content

drm/i915: drm/i915/tgl+: Enable DC power states on all eDP ports

Imre Deak intel-gfx 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest9 patches 2 repliesIn review
  2. v36 of 9 patches 19 repliesSuperseded
  3. v29 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v17 patches8 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/i915: Fix warn in intel_display_power_*_domain() functionsdrivers/gpu/drm/i915/display/intel_display_power.c+4 -40 replies
2/9drm/i915: Preallocate the debug power domain wakerefs arraydrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_types.h+6 -60 replies
3/9drm/i915: Move the POWER_DOMAIN_AUX_IO_A definition to its logical placedrivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h drivers/gpu/drm/i915/display/intel_display_power_map.c+8 -70 replies
4/9drm/i915: Use the AUX_IO power domain only for eDP/PSR portdrivers/gpu/drm/i915/display/intel_ddi.c+4 -20 replies
5/9drm/i915/tgl+: Enable display DC power states on all eDP portsdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display_power.c drivers/gpu/drm/i915/display/intel_display_power.h +1 more+89 -70 replies
6/9drm/i915: Add missing AUX_IO_A power domain->well mappingsdrivers/gpu/drm/i915/display/intel_display_power_map.c+2 -00 replies
7/9drm/i915: Add missing DC_OFF power domain->well mappingsdrivers/gpu/drm/i915/display/intel_display_power_map.c+8 -00 replies
8/9drm/i915: Factor out function to get/put AUX_IO power for main linkdrivers/gpu/drm/i915/display/intel_ddi.c+52 -330 replies
9/9drm/i915/mtl+: Don't enable the AUX_IO power for non-eDP port main linksdrivers/gpu/drm/i915/display/intel_ddi.c+3 -22 replies

Reviews trailers per patch

1 of 9 patches has a Reviewed-by or Acked-by.

PatchVille Syrjälä
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Intel-gfx] [PATCH v4 0/9] drm/i915: drm/i915/tgl+: Enable DC power states on all eDP ports

This is v4 of [1] addressing the review comments from Ville:

- Use preallocated memory for the intel_display_power_get/put_in_set() debug wakerefs array.
- Drop the
"drm/i915: Don't enable the AUX_IO power for combo-PHY external DP port main links" patch, to keep the existing behavior for now on the external DP ports.

Cc Ville Syrjälä <[email protected]>
Cc Jani Nikula <[email protected]>

[1] https://lore.kernel.org/intel-gfx/[email protected]/T/#t

Imre Deak (9):
drm/i915: Fix warn in intel_display_power_*_domain() functions drm/i915: Preallocate the debug power domain wakerefs array drm/i915: Move the POWER_DOMAIN_AUX_IO_A definition to its logical
place
drm/i915: Use the AUX_IO power domain only for eDP/PSR port drm/i915/tgl+: Enable display DC power states on all eDP ports drm/i915: Add missing AUX_IO_A power domain->well mappings drm/i915: Add missing DC_OFF power domain->well mappings drm/i915: Factor out function to get/put AUX_IO power for main link drm/i915/mtl+: Don't enable the AUX_IO power for non-eDP port main
links

 drivers/gpu/drm/i915/display/intel_ddi.c      | 92 ++++++++++++-------
 drivers/gpu/drm/i915/display/intel_display.c  | 11 +--
 .../drm/i915/display/intel_display_power.c    | 42 +++++++--
 .../drm/i915/display/intel_display_power.h    | 12 ++-
 .../i915/display/intel_display_power_map.c    | 69 ++++++++++++--
 .../drm/i915/display/intel_display_types.h    |  1 +
 6 files changed, 171 insertions(+), 56 deletions(-)
Signature · 1 line
2.37.1