misc-utils: flashcp: Bugfixes to --partition
Status from this message: Applied to mtd-utils.git master.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | misc-utils: flashcp: add safe_writemisc-utils/ | +25 | 0 replies | |
| 2/7 | misc-utils: flashcp: check for lseek errorsmisc-utils/ | +16 | 0 replies | |
| 3/7 | misc-utils: flashcp: add safe_memerasemisc-utils/ | +15 | 0 replies | |
| 4/7 | misc-utils: flashcp: simplify loggingmisc-utils/ | +77 | 0 replies | |
| 5/7 | misc-utils: flashcp: fix buffer overflowmisc-utils/ | +13 | 0 replies | |
| 6/7 | misc-utils: flashcp: verify data in --partitionmisc-utils/ | +9 | 0 replies | |
| 7/7 | misc-utils: flashcp: abort on --partition and --erase-allmisc-utils/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH mtd-utils 0/7] misc-utils: flashcp: Bugfixes to --partition
Discovered an assortment of issues with the flashcp --partition code:
- not checking lseek() for errors
- overflowing the src and dest buffers
- not verifying data is written succesfully
- silently ignoring --erase-all
The patches "add safe_*" and "simplify logging" do not fix bugs but are code cleanup.
Brandon Maier (7):
misc-utils: flashcp: add safe_write
misc-utils: flashcp: check for lseek errors
misc-utils: flashcp: add safe_memerase
misc-utils: flashcp: simplify logging
misc-utils: flashcp: fix buffer overflow
misc-utils: flashcp: verify data in --partition
misc-utils: flashcp: abort on --partition and --erase-all
misc-utils/flashcp.c | 284 +++++++++++++++++++++---------------------- 1 file changed, 138 insertions(+), 146 deletions(-)
Signature · 6 lines
2.38.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/