Skip to content

misc-utils: flashcp: Bugfixes to --partition

Brandon Maier linux-mtd 1 version Applied

Status from this message: Applied to mtd-utils.git master.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/7misc-utils: flashcp: add safe_writemisc-utils/flashcp.c+25 -330 replies
2/7misc-utils: flashcp: check for lseek errorsmisc-utils/flashcp.c+16 -60 replies
3/7misc-utils: flashcp: add safe_memerasemisc-utils/flashcp.c+15 -230 replies
4/7misc-utils: flashcp: simplify loggingmisc-utils/flashcp.c+77 -960 replies
5/7misc-utils: flashcp: fix buffer overflowmisc-utils/flashcp.c+13 -80 replies
6/7misc-utils: flashcp: verify data in --partitionmisc-utils/flashcp.c+9 -00 replies
7/7misc-utils: flashcp: abort on --partition and --erase-allmisc-utils/flashcp.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH mtd-utils 0/7] misc-utils: flashcp: Bugfixes to --partition

Discovered an assortment of issues with the flashcp --partition code:
- not checking lseek() for errors
- overflowing the src and dest buffers
- not verifying data is written succesfully
- silently ignoring --erase-all

The patches "add safe_*" and "simplify logging" do not fix bugs but are code cleanup.

Brandon Maier (7):
misc-utils: flashcp: add safe_write
misc-utils: flashcp: check for lseek errors
misc-utils: flashcp: add safe_memerase
misc-utils: flashcp: simplify logging
misc-utils: flashcp: fix buffer overflow
misc-utils: flashcp: verify data in --partition
misc-utils: flashcp: abort on --partition and --erase-all

 misc-utils/flashcp.c | 284 +++++++++++++++++++++----------------------
 1 file changed, 138 insertions(+), 146 deletions(-)
Signature · 6 lines
2.38.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/