Skip to content

fix direct io device mapper errors

Keith Busch dm-devel linux-block 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 8 repliesApplied
  2. v13 patches 8 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5block: make dma_alignment a stacking queue_limitblock/blk-core.c block/blk-settings.c include/linux/blkdev.h+13 -110 replies
2/5dm-crypt: provide dma_alignment limit in io_hintsdrivers/md/dm-crypt.c+1 -01 reply
3/5block: make blk_set_default_limits() privateblock/blk-settings.c block/blk.h include/linux/blkdev.h+1 -20 replies
4/5dm-integrity: set dma_alignment limit in io_hintsdrivers/md/dm-integrity.c+1 -01 reply
5/5dm-log-writes: set dma_alignment limit in io_hintsdrivers/md/dm-log-writes.c+1 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchEric BiggersChristoph HellwigMike Snitzer
1/5R-b
2/5Reportred-by R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCHv2 0/5] fix direct io device mapper errors

From: Keith Busch <[email protected]>

The 6.0 kernel made some changes to the direct io interface to allow offsets in user addresses. This based on the hardware's capabilities reported in the request_queue's dma_alignment attribute.

dm-crypt, -log-writes and -integrity require direct io be aligned to the block size. Since it was only ever using the default 511 dma mask, this requirement may fail if formatted to something larger, like 4k, which will result in unexpected behavior with direct-io.

Changes since v1: Added the same fix for -integrity and -log-writes

The first three were reported successfully tested by Dmitrii Tcvetkov, but I don't have an official Tested-by: tag.

https://lore.kernel.org/linux-block/[email protected]/T/#mba1d0b13374541cdad3b669ec4257a11301d1860

Keitio errors on Busch (5):
block: make dma_alignment a stacking queue_limit
dm-crypt: provide dma_alignment limit in io_hints
block: make blk_set_default_limits() private
dm-integrity: set dma_alignment limit in io_hints
dm-log-writes: set dma_alignment limit in io_hints

 block/blk-core.c           |  1 -
 block/blk-settings.c       |  9 +++++----
 block/blk.h                |  1 +
 drivers/md/dm-crypt.c      |  1 +
 drivers/md/dm-integrity.c  |  1 +
 drivers/md/dm-log-writes.c |  1 +
 include/linux/blkdev.h     | 16 ++++++++--------
 7 files changed, 17 insertions(+), 13 deletions(-)
Signature · 1 line
2.30.2