Skip to content

Add pci_dev_for_each_resource() helper and update users

Andy Shevchenko linux-acpi linux-alpha linux-arm-kernel linux-mips linux-pci linux-sh linuxppc-dev lkml sparclinux xen-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest7 patches 17 repliesIn review
  2. v76 patches 6 repliesSuperseded
  3. v64 patches 6 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v54 patches0 repliesSuperseded
v44 patches4 repliesSuperseded
v34 patches1 replySuperseded
v24 patches8 repliesSuperseded

Changes in v8 from the cover letter

- fixed issue with pci_bus_for_each_resource() macro (LKP)
- due to above added a new patch to document how it works
- moved the last patch to be #2 (Philippe)
- added tags (Philippe)

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7kernel.h: Split out COUNT_ARGS() and CONCATENATE()include/linux/args.h include/linux/kernel.h+14 -70 replies
2/7PCI: Introduce pci_resource_n()include/linux/pci.h+7 -80 replies
3/7PCI: Introduce pci_dev_for_each_resource().clang-format arch/alpha/kernel/pci.c arch/arm/kernel/bios32.c +20 more+112 -1320 replies
4/7PCI: Document pci_bus_for_each_resource() to avoid confusioninclude/linux/pci.h+20 -00 replies
5/7PCI: Allow pci_bus_for_each_resource() to take less argumentsdrivers/pci/bus.c drivers/pci/hotplug/shpchp_sysfs.c drivers/pci/pci.c +3 more+32 -222 replies
6/7EISA: Convert to use less arguments in pci_bus_for_each_resource()drivers/eisa/pci_eisa.c+2 -20 replies
7/7pcmcia: Convert to use less arguments in pci_bus_for_each_resource()drivers/pcmcia/rsrc_nonstatic.c drivers/pcmcia/yenta_socket.c+4 -81 reply

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéKrzysztof WilczyńskiDominik Brodowski
1/7
2/7R-b
3/7R-b
4/7
5/7R-b R-b
6/7R-b R-b
7/7R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH v8 0/7] Add pci_dev_for_each_resource() helper and update users

Provide two new helper macros to iterate over PCI device resources and convert users.

Looking at it, refactor existing pci_bus_for_each_resource() and convert users accordingly.

Note, the amount of lines grew due to the documentation update.

Changelog v8:
- fixed issue with pci_bus_for_each_resource() macro (LKP)
- due to above added a new patch to document how it works
- moved the last patch to be #2 (Philippe)
- added tags (Philippe)

Changelog v7:
- made both macros to share same name (Bjorn)
- split out the pci_resource_n() conversion (Bjorn)

Changelog v6:
- dropped unused variable in PPC code (LKP)

Changelog v5:
- renamed loop variable to minimize the clash (Keith)
- addressed smatch warning (Dan)
- addressed 0-day bot findings (LKP)

Changelog v4:
- rebased on top of v6.3-rc1
- added tag (Krzysztof)

Changelog v3:
- rebased on top of v2 by Mika, see above
- added tag to pcmcia patch (Dominik)

Changelog v2:
- refactor to have two macros
- refactor existing pci_bus_for_each_resource() in the same way and convert users

Andy Shevchenko (6):
kernel.h: Split out COUNT_ARGS() and CONCATENATE()
PCI: Introduce pci_resource_n()
PCI: Document pci_bus_for_each_resource() to avoid confusion
PCI: Allow pci_bus_for_each_resource() to take less arguments
EISA: Convert to use less arguments in pci_bus_for_each_resource()
pcmcia: Convert to use less arguments in pci_bus_for_each_resource()

Mika Westerberg (1):
PCI: Introduce pci_dev_for_each_resource()

 .clang-format                             |  1 +
 arch/alpha/kernel/pci.c                   |  5 +-
 arch/arm/kernel/bios32.c                  | 16 +++--
 arch/arm/mach-dove/pcie.c                 | 10 ++--
 arch/arm/mach-mv78xx0/pcie.c              | 10 ++--
 arch/arm/mach-orion5x/pci.c               | 10 ++--
 arch/mips/pci/ops-bcm63xx.c               |  8 +--
 arch/mips/pci/pci-legacy.c                |  3 +-
 arch/powerpc/kernel/pci-common.c          | 21 +++----
 arch/powerpc/platforms/4xx/pci.c          |  8 +--
 arch/powerpc/platforms/52xx/mpc52xx_pci.c |  5 +-
 arch/powerpc/platforms/pseries/pci.c      | 16 ++---
 arch/sh/drivers/pci/pcie-sh7786.c         | 10 ++--
 arch/sparc/kernel/leon_pci.c              |  5 +-
 arch/sparc/kernel/pci.c                   | 10 ++--
 arch/sparc/kernel/pcic.c                  |  5 +-
 drivers/eisa/pci_eisa.c                   |  4 +-
 drivers/pci/bus.c                         |  7 +--
 drivers/pci/hotplug/shpchp_sysfs.c        |  8 +--
 drivers/pci/pci.c                         |  3 +-
 drivers/pci/probe.c                       |  2 +-
 drivers/pci/remove.c                      |  5 +-
 drivers/pci/setup-bus.c                   | 37 +++++-------
 drivers/pci/setup-res.c                   |  4 +-
 drivers/pci/vgaarb.c                      | 17 ++----
 drivers/pci/xen-pcifront.c                |  4 +-
 drivers/pcmcia/rsrc_nonstatic.c           |  9 +--
 drivers/pcmcia/yenta_socket.c             |  3 +-
 drivers/pnp/quirks.c                      | 29 ++++-----
 include/linux/args.h                      | 13 ++++
 include/linux/kernel.h                    |  8 +--
 include/linux/pci.h                       | 72 +++++++++++++++++++----
 32 files changed, 190 insertions(+), 178 deletions(-)
 create mode 100644 include/linux/args.h
Signature · 1 line
2.40.0.1.gaa8946217a0b