Skip to content

Fix the "-nic help" option

Thomas Huth qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 18 repliesSuperseded

Changes in v2 from the cover letter

- Add function comment in the first patch
- Add Reviewed-by in the third patch

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net: Move the code to collect available NIC models to a separate functionhw/pci/pci.c include/net/net.h net/net.c+49 -280 replies
2/3net: Restore printing of the help text with "-nic help"net/net.c+12 -20 replies
3/3net: Replace "Supported NIC models" with "Available NIC models"net/net.c+1 -10 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchClaudio Fontana
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Fix the "-nic help" option

Running QEMU with "-nic help" used to work in QEMU 5.2 and earlier versions, but since QEMU 6.0 it just complains that "help" is not a valid value here. This patch series fixes this problem and also extends the help output here to list the available NIC models, too.

v2:
- Add function comment in the first patch
- Add Reviewed-by in the third patch

Thomas Huth (3):
net: Move the code to collect available NIC models to a separate
function
net: Restore printing of the help text with "-nic help"
net: Replace "Supported NIC models" with "Available NIC models"

 include/net/net.h | 14 +++++++++++++
 hw/pci/pci.c      | 29 +--------------------------
 net/net.c         | 50 ++++++++++++++++++++++++++++++++++++++++++++---
 3 files changed, 62 insertions(+), 31 deletions(-)
Signature · 1 line
2.31.1