Skip to content

KVM: allow listener to stop all vcpus before

Emanuele Giuseppe Esposito kvm qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 9 repliesIn review
  2. v23 patches 4 repliesSuperseded
  3. v1 RFC3 patches 1 replySuperseded

Changes in v3 from the cover letter

* minor fixes on comments and docs
* improved accel_ioctl_inhibit_begin
* drop QSIMPLEQ_REMOVE from kvm_commit

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3accel: introduce accelerator blocker APIaccel/accel-blocker.c accel/meson.build hw/core/cpu-common.c +2 more+216 -13 replies
2/3KVM: keep track of running ioctlsaccel/kvm/kvm-all.c+7 -06 replies
3/3kvm: Atomic memslot updatesaccel/kvm/kvm-all.c include/sysemu/kvm_int.h+98 -110 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchEmanuele Giuseppe EspositoPhilippe Mathieu-Daudé
1/3R-b
2/3
3/3T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] KVM: allow listener to stop all vcpus before

QEMU needs to perform memslots operations like merging and splitting, and each operation requires more than a single ioctl. Therefore if a vcpu is concurrently reading the same memslots, it could end up reading something that was temporarly deleted. For example, merging two memslots into one would imply:
DELETE(m1)
DELETE(m2)
CREATE(m1+m2)

And a vcpu could attempt to read m2 right after it is deleted, but before the new one is created.

This approach is 100% QEMU-based. No KVM API modification is involved, but implies that QEMU must make sure no new ioctl is running and all vcpus are stopped.

The logic and code are basically taken from David Hildenbrand proposal given a while ago while reviewing a previous attempt where I suggested to solve the above problem directly in KVM by extending its API.

This is the original code:
https://github.com/davidhildenbrand/qemu/commit/86b1bf546a8d00908e33f7362b0b61e2be8dbb7a

I just split the patch in three smaller patches, and used a QemuLockCnt instead of counter + mutex.

RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1979276

Emanuele
---
v3:
* minor fixes on comments and docs
* improved accel_ioctl_inhibit_begin
* drop QSIMPLEQ_REMOVE from kvm_commit

v2:
* use QemuEvent instead of spinning in ioctl_inhibit_begin
* move the blocker API in a separate file and header, so that other accel can use it if they want.

David Hildenbrand (1):
kvm: Atomic memslot updates

Emanuele Giuseppe Esposito (2):
accel: introduce accelerator blocker API
KVM: keep track of running ioctls

 accel/accel-blocker.c          | 154 +++++++++++++++++++++++++++++++++
 accel/kvm/kvm-all.c            | 108 ++++++++++++++++++++---
 accel/meson.build              |   2 +-
 hw/core/cpu-common.c           |   2 +
 include/hw/core/cpu.h          |   3 +
 include/sysemu/accel-blocker.h |  56 ++++++++++++
 include/sysemu/kvm_int.h       |   8 ++
 7 files changed, 321 insertions(+), 12 deletions(-)
 create mode 100644 accel/accel-blocker.c
 create mode 100644 include/sysemu/accel-blocker.h
Signature · 1 line
2.31.1